[GitHub] wohali commented on issue #1734: Stop replications on target document write failures

[GitBox <gi...@apache.org>]

wohali commented on issue #1734: Stop replications on target document write failures
URL: https://github.com/apache/couchdb/pull/1734#issuecomment-438374131
 
 
   I think the fundamental problem you're trying to solve here is surfacing the failures to the user.
   
   Currently the replication status fields aren't rich enough to capture "Succeeded, but with errors" as a new end state. I would argue strongly that we need that state, that Fauxton needs to display it in a different colour, and that the specific types of failures should be enumerated (along with the total # of documents that _successfully_ replicated).
   
   Note as well that continuous replications could be in a "Succeeding/running, but with errors" state as well that should be called out.
   
   The problem is that client code needs to be rewritten. Many replication monitoring scripts that I've run into in the wild tend to be of the sort "start the replication, check `/_active_tasks` or `scheduler/jobs`, if not errored, everything is fine, when it hits succeeded, we're good." Those scripts will have to be taught to react to the new state.
   
   -----
   
   At the very least, failing on a single document write seems overkill. If this proposal is to proceed, I'd recommend changing your setting to:
   
   ```
   stop_on_doc_write_failure = false ; current behaviour
   stop_on_doc_write_failure = ### ; stops after ### failures occur
   stop_on_doc_write_failure = true ; same as = 1
   ```
   
   -----
   
   
   Either way, this is too big of a change to go into 2.3.0 (which is imminent) so I'd ask you to hold off on merging this PR for now if approved. If I had to express a numerical opinion, it'd be -0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services