You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/19 10:47:27 UTC

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

Hello Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5544

to review the following change.

Change subject: delete_table_test: improve test runtime in ASAN/TSAN
......................................................................

delete_table_test: improve test runtime in ASAN/TSAN

TestDeleteTableWhileScanInProgress was running almost 10 minutes in ASAN
builds. This was causing the suite to time out and show up on the flaky
list.

Change-Id: I255fedd9ddd13f0e3351af6e7dcd6bdab4bc945d
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/5544/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I255fedd9ddd13f0e3351af6e7dcd6bdab4bc945d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.

Change subject: delete_table_test: improve test runtime in ASAN/TSAN
......................................................................


delete_table_test: improve test runtime in ASAN/TSAN

TestDeleteTableWhileScanInProgress was running almost 10 minutes in ASAN
builds. This was causing the suite to time out and show up on the flaky
list.

Change-Id: I255fedd9ddd13f0e3351af6e7dcd6bdab4bc945d
Reviewed-on: http://gerrit.cloudera.org:8080/5544
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I255fedd9ddd13f0e3351af6e7dcd6bdab4bc945d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: delete_table_test: improve test runtime in ASAN/TSAN
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255fedd9ddd13f0e3351af6e7dcd6bdab4bc945d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No