You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/12/14 18:16:35 UTC
[kudu-CR] [client] add WARN UNUSED RESULT for a few static functions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12090
Change subject: [client] add WARN_UNUSED_RESULT for a few static functions
......................................................................
[client] add WARN_UNUSED_RESULT for a few static functions
This patch adds the WARN_UNUSED_RESULT attribute for the following
static functions in the kudu::client namespace:
* SetInternalSignalNumber(int signum)
* DisableSaslInitialization()
* DisableOpenSSLInitialization()
This change does not affect the exported symbols of the above mentioned
functions in the kudu_client library, so this change is
backward-compatible.
Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
---
M src/kudu/client/client.h
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/12090/1
--
To view, visit http://gerrit.cloudera.org:8080/12090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
Gerrit-Change-Number: 12090
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] add WARN UNUSED RESULT for a few static functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12090 )
Change subject: [client] add WARN_UNUSED_RESULT for a few static functions
......................................................................
[client] add WARN_UNUSED_RESULT for a few static functions
This patch adds the WARN_UNUSED_RESULT attribute for the following
static functions in the kudu::client namespace:
* SetInternalSignalNumber(int signum)
* DisableSaslInitialization()
* DisableOpenSSLInitialization()
This change does not affect the exported symbols of the above mentioned
functions in the kudu_client library, so this change is
backward-compatible.
Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
Reviewed-on: http://gerrit.cloudera.org:8080/12090
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
Gerrit-Change-Number: 12090
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] add WARN UNUSED RESULT for a few static functions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12090 )
Change subject: [client] add WARN_UNUSED_RESULT for a few static functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
Gerrit-Change-Number: 12090
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Dec 2018 19:13:10 +0000
Gerrit-HasComments: No