You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/10 21:49:02 UTC
Review Request 35321: Implemented the fixed resource estimator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35321/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-2791
https://issues.apache.org/jira/browse/MESOS-2791
Repository: mesos
Description
-------
Implemented the fixed resource estimator.
Diffs
-----
src/slave/resource_estimators/fixed.cpp 3efa18d7e3c6ac62e67f75ea45a832f3f6349036
src/tests/oversubscription_tests.cpp 59cf07ef93460537ce1343793fd4a5d11d2ae242
Diff: https://reviews.apache.org/r/35321/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 35321: Implemented the fixed resource estimator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35321/#review87454
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35259, 35260, 35264, 35305, 35320, 35321]
All tests passed.
- Mesos ReviewBot
On June 10, 2015, 7:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35321/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 7:49 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2791
> https://issues.apache.org/jira/browse/MESOS-2791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the fixed resource estimator.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/fixed.cpp 3efa18d7e3c6ac62e67f75ea45a832f3f6349036
> src/tests/oversubscription_tests.cpp 59cf07ef93460537ce1343793fd4a5d11d2ae242
>
> Diff: https://reviews.apache.org/r/35321/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35321: Implemented the fixed resource estimator.
Posted by Jie Yu <yu...@gmail.com>.
> On June 11, 2015, 1:07 a.m., Ben Mahler wrote:
> > src/tests/oversubscription_tests.cpp, lines 404-406
> > <https://reviews.apache.org/r/35321/diff/1/?file=982246#file982246line404>
> >
> > s/since the FixedResourcesEstimator is used//
> >
> > and maybe wrap to reduce jaggedness?
> >
> > ```
> > // Launch a task that uses revocable resources and verify
> > // that the total oversubscribed resources does not change.
> > ```
> >
> > Maybe do a pass in the rest of this test too?
Removed the unneeded comments and adjust the wrapping.
> On June 11, 2015, 1:07 a.m., Ben Mahler wrote:
> > src/tests/oversubscription_tests.cpp, line 434
> > <https://reviews.apache.org/r/35321/diff/1/?file=982246#file982246line434>
> >
> > "revocable" with a c
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35321/#review87498
-----------------------------------------------------------
On June 10, 2015, 7:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35321/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 7:49 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2791
> https://issues.apache.org/jira/browse/MESOS-2791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the fixed resource estimator.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/fixed.cpp 3efa18d7e3c6ac62e67f75ea45a832f3f6349036
> src/tests/oversubscription_tests.cpp 59cf07ef93460537ce1343793fd4a5d11d2ae242
>
> Diff: https://reviews.apache.org/r/35321/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35321: Implemented the fixed resource estimator.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35321/#review87498
-----------------------------------------------------------
Ship it!
src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35321/#comment139843>
How about just s/resources/totalRevocable/ so that we don't need to clarify with this note? Then we can CHECK this in teh constructor (which it looks like we should do anyway?)
src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35321/#comment139844>
s/since the FixedResourcesEstimator is used//
and maybe wrap to reduce jaggedness?
```
// Launch a task that uses revocable resources and verify
// that the total oversubscribed resources does not change.
```
Maybe do a pass in the rest of this test too?
src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35321/#comment139845>
"revocable" with a c
- Ben Mahler
On June 10, 2015, 7:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35321/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 7:49 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2791
> https://issues.apache.org/jira/browse/MESOS-2791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the fixed resource estimator.
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/fixed.cpp 3efa18d7e3c6ac62e67f75ea45a832f3f6349036
> src/tests/oversubscription_tests.cpp 59cf07ef93460537ce1343793fd4a5d11d2ae242
>
> Diff: https://reviews.apache.org/r/35321/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>