You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@arrow.apache.org by "stephane campinas (Jira)" <ji...@apache.org> on 2019/11/19 11:55:00 UTC

[jira] [Created] (ARROW-7206) avoid string concatenation when calling Preconditions#checkArgument

stephane campinas created ARROW-7206:
----------------------------------------

             Summary: avoid string concatenation when calling Preconditions#checkArgument
                 Key: ARROW-7206
                 URL: https://issues.apache.org/jira/browse/ARROW-7206
             Project: Apache Arrow
          Issue Type: Improvement
          Components: Java
            Reporter: stephane campinas
            Assignee: stephane campinas
         Attachments: after.png, before.png

Preconditions#checkArgument is called in VectorLoader with the String message already built.

This causes some noticeable overhead as can be seen from the attached flame graphs.

 

Calling checkArgument with an error template instead avoids the call to StringBuilder as can be seen in the `after` image.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)