You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "agubler (via GitHub)" <gi...@apache.org> on 2023/03/09 17:52:25 UTC
[GitHub] [superset] agubler opened a new pull request, #23321: feat(dashboard): expose the embedded dashboard configuration on the api
agubler opened a new pull request, #23321:
URL: https://github.com/apache/superset/pull/23321
### SUMMARY
Adds an embedded property to the existing dashboard API that returns the embedded configuration if it exists. This users can use the API with a single call to get a list of embeddable dashboards, whilst currently this would require an extra API request per dashboard.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
Run the branch, set the `EMBEDDED_SUPERSET` to `True` and configure a dashboard as embeddable within the UI. Request the dashboard api from `/api/v1/dashboard` and request the specific dashboard api from `/api/v1/dashboard/{id}` and review the embedded configuration.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
If there are additional automated tests that need adding and/or if the embedded configuration on the API needs to be behind the same `EMBEDDED_SUPERSET` please let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): expose the embedded dashboard configuration on the api [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23321:
URL: https://github.com/apache/superset/pull/23321#issuecomment-2528869019
Marking this as a draft until it gets rebased. It may be closed eventually if that doesn't happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): expose the embedded dashboard configuration on the api [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23321:
URL: https://github.com/apache/superset/pull/23321#issuecomment-2791172996
This has been in draft mode awaiting updates since December. It doesn't seem likely to become ready for merge at this point, so we'll close this PR to help keep the backlog manageable. Please feel free to reopen (or ping me to) if you still want to get this through. We appreciate the contribution in either case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): expose the embedded dashboard configuration on the api [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23321: feat(dashboard): expose the embedded dashboard configuration on the api
URL: https://github.com/apache/superset/pull/23321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): expose the embedded dashboard configuration on the api [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23321:
URL: https://github.com/apache/superset/pull/23321#issuecomment-1936527588
Thanks for the contribution, and sorry this slipped under the radar for so long. Would you be willing to give this a rebase? I'll add a couple potential reviewers in the meantime that might be able to assess/raise any api/scaling/security questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org