You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/10 14:03:09 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #3056: implement except node

morningman commented on a change in pull request #3056: implement except node
URL: https://github.com/apache/incubator-doris/pull/3056#discussion_r390335009
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SetOperationStmt.java
 ##########
 @@ -649,6 +648,13 @@ public void analyze(Analyzer parent) throws AnalysisException, UserException {
             if (isAnalyzed()) {
                 return;
             }
+            if (queryStmt instanceof SelectStmt && ((SelectStmt) queryStmt).fromClause_.isEmpty()) {
 
 Review comment:
   What this for? Could you add comment to explain this rewrite?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org