[jira] [Commented] (DRILL-5042) Settings in drill-env.sh are not overriding the same settings in distrib-env.sh

["Paul Rogers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672065#comment-15672065 ] 

Paul Rogers commented on DRILL-5042:
------------------------------------

Turns out that Drill works correctly, but the particular distrib-env.sh file was formatted wrong. Here is the proper way to set variables in distrib-env.sh:

export DRILL_HEAP=${DRILL_HEAP:-"5G"}

This form says "if no one else set the variable, set it to 5G."

This format is important so that values set in the environment override those set in scripts. If drill-env.sh and distrib-env.sh both use this form, then the order of overrides, from highest-to-lowest priority, is:

* Environment
* drill-env.sh
* distrib-env.sh
* Drill defaults (in drill-config.sh)

And, using this form means that drill-config.sh should read drill-env.sh before distrib-env.sh, which it does.


> Settings in drill-env.sh are not overriding the same settings in distrib-env.sh
> -------------------------------------------------------------------------------
>
>                 Key: DRILL-5042
>                 URL: https://issues.apache.org/jira/browse/DRILL-5042
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.9.0
>            Reporter: Krystal
>            Assignee: Paul Rogers
>
> commit id: d925f738d006caedf8635db1024825e355b5dada
> currently, settings from drill-env.sh are not overriding those from distrib-env.sh.  Instead, the ones from distrib-env.sh are overriding the same setting from drill-env.sh.
> The correct behavior is that the settings from drill-env.sh should override the same settings in distrib-env.sh.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)