You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2016/01/09 12:22:39 UTC
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1326
New test to validate starting vm after nic removal and attach
Please refer bug CLOUDSTACK-9219 for more details.
Test Results:
==========
Test to verify vm start after NIC removal and reattach ... === TestName: test_30_remove_nic_reattach | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 277.478s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack cs-9219
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1326
----
commit 4aa45d9f174e288bde119efd1ca0a1bafb7094fc
Author: sanjeevn <sa...@citrix.com>
Date: 2016-01-08T13:19:27Z
New test to validate starting vm after nic removal and attach
Bug-Id: CLOUDSTACK-9219
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1326#discussion_r58685208
--- Diff: test/integration/component/test_add_remove_network.py ---
@@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self):
self.fail("Failed to delete the nic from vm")
return
+ @attr(tags=["advanced"], required_hardware="true")
+ def test_30_remove_nic_reattach(self):
+ """
+ Test to verify vm start after NIC removal and reattach
+
+ # 1.Create vm which has 3 nics(e.g. #0,#1,#2)
+ # 2.Stop the vm
+ # 3.Remove second nic(#1)
+ # 4.Add/Reattach same network(#1)
+ # 5.Start the instance
+ """
+ self.ntwk2 = Network.create(
+ self.apiclient,
+ self.services["isolated_network"],
+ self.account.name,
+ self.account.domainid,
+ networkofferingid=self.isolated_network_offering.id
+ )
+ self.ntwk3 = Network.create(
+ self.apiclient,
+ self.services["isolated_network"],
+ self.account.name,
+ self.account.domainid,
+ networkofferingid=self.isolated_network_offering.id
+ )
+ self.test_vm = VirtualMachine.create(
+ self.apiclient,
+ self.services["virtual_machine"],
+ accountid=self.account.name,
+ domainid=self.account.domainid,
+ serviceofferingid=self.service_offering.id,
+ mode=self.zone.networktype,
+ networkids=[self.isolated_network.id, self.ntwk2.id, self.ntwk3.id]
+ )
+ self.assertIsNotNone(self.test_vm, "Failed to create vm with 3 nics")
+ map(lambda x: self.cleanup.append(x), [self.test_vm, self.ntwk2, self.ntwk3])
+ vm_res = VirtualMachine.list(
+ self.apiclient,
+ id=self.test_vm.id
+ )
+ self.assertEqual(validateList(vm_res)[0], PASS, "Invalid list vm response")
+ self.nics = vm_res[0].nic
+ self.assertEqual(
+ validateList(self.nics)[0],
+ PASS,
+ "vm response does not conain nics info"
--- End diff --
@GabrielBrascher , I have corrected the type. Can you please review and give LGTM ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212776381
@swill This has 2 LGTMs and also CI results. The failures are unrelated as this PR only adds new test cases and no product code changes. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
RE: [GitHub] cloudstack pull request: New test to validate starting
vm after ni...
Posted by Sanjeev Neelarapu <sa...@accelerite.com>.
Those failures are false positives.
Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelarapu@accelerite.com
-----Original Message-----
From: GabrielBrascher [mailto:git@git.apache.org]
Sent: Wednesday, April 06, 2016 7:45 PM
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: New test to validate starting vm after ni...
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206391435
Based on the code LGTM.
However, I am not sure if should consider those failed tests ("integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRang", "integration.smoke.test_loadbalance.TestLoadBalance") are they false positive?
---
If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA.
---
DISCLAIMER
==========
This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206391435
Based on the code LGTM.
However, I am not sure if should consider those failed tests ("integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRang", "integration.smoke.test_loadbalance.TestLoadBalance") are they false positive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1326#discussion_r57545397
--- Diff: test/integration/component/test_add_remove_network.py ---
@@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self):
self.fail("Failed to delete the nic from vm")
return
+ @attr(tags=["advanced"], required_hardware="true")
+ def test_30_remove_nic_reattach(self):
+ """
+ Test to verify vm start after NIC removal and reattach
+
+ # 1.Create vm which has 3 nics(e.g. #0,#1,#2)
+ # 2.Stop the vm
+ # 3.Remove second nic(#1)
+ # 4.Add/Reattach same network(#1)
+ # 5.Start the instance
+ """
+ self.ntwk2 = Network.create(
+ self.apiclient,
+ self.services["isolated_network"],
+ self.account.name,
+ self.account.domainid,
+ networkofferingid=self.isolated_network_offering.id
+ )
+ self.ntwk3 = Network.create(
+ self.apiclient,
+ self.services["isolated_network"],
+ self.account.name,
+ self.account.domainid,
+ networkofferingid=self.isolated_network_offering.id
+ )
+ self.test_vm = VirtualMachine.create(
+ self.apiclient,
+ self.services["virtual_machine"],
+ accountid=self.account.name,
+ domainid=self.account.domainid,
+ serviceofferingid=self.service_offering.id,
+ mode=self.zone.networktype,
+ networkids=[self.isolated_network.id, self.ntwk2.id, self.ntwk3.id]
+ )
+ self.assertIsNotNone(self.test_vm, "Failed to create vm with 3 nics")
+ map(lambda x: self.cleanup.append(x), [self.test_vm, self.ntwk2, self.ntwk3])
+ vm_res = VirtualMachine.list(
+ self.apiclient,
+ id=self.test_vm.id
+ )
+ self.assertEqual(validateList(vm_res)[0], PASS, "Invalid list vm response")
+ self.nics = vm_res[0].nic
+ self.assertEqual(
+ validateList(self.nics)[0],
+ PASS,
+ "vm response does not conain nics info"
--- End diff --
Hi @sanju1010, just a small typo here ("vm response does not **conain** nics info" -> "... **contain**..."). Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-201368034
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
### ACS CI BVT Run
**Sumarry:**
Build Number 128
Hypervisor xenserver
NetworkType Advanced
Passed=99
Failed=4
Skipped=4
**Failed tests:**
* integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
* test_dedicateGuestVlanRange Failing since 3 runs
* integration.smoke.test_loadbalance.TestLoadBalance
* test_01_create_lb_rule_src_nat Failed
* test_02_create_lb_rule_non_nat Failed
* test_assign_and_removal_lb Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_disk_offerings.TestCreateDiskOffering
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-170358521
LGTM based on the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206462142
I think all of the tests that fail regularly have been removed from that test suite now. I believe we need all those tests passing, so we should review the failures. I can add this to my queue for testing in my CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: New test to validate starting vm after ni...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212910562
Thanks, I will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---