You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/07 14:53:02 UTC

[GitHub] [spark] bersprockets commented on pull request #37825: [SPARK-40382][SQL][WIP] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

bersprockets commented on PR #37825:
URL: https://github.com/apache/spark/pull/37825#issuecomment-1271702293

   > LGTM. Can you rebase to the latest master branch to retrigger github action jobs?
   
   Will do.
   
   I still have this as WIP because I don't understand the impact, if any, of passing attributes created from the non-rewritten distinct aggregate expressions to the xxxAggregateExec constructor as `aggregateAttributes` ([here](https://github.com/apache/spark/blob/e19b16f68c5114f97335273da57f833f051af6cc/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala#L263)). So I was going to review that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org