You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2023/06/01 19:53:11 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #6010: On JDKs without JavaFX/OpenFX libs.javafx has unsatisfiable package dependency
matthiasblaesing opened a new pull request, #6010:
URL: https://github.com/apache/netbeans/pull/6010
With this commit:
> commit 15811ec850cc3cfe50eeaffd96c2eae1065ccb9c
> Author: Svata Dedic <sv...@oracle.com>
> Date: Tue Apr 18 14:10:14 2023 +0200
>
> Allow java and (system) package dependencies for eager modules.
> Provider autoloads with failed dependencies have problems reported.
dependency checking was improved and in turn module configurations that worked by luck failed to load.
For `libs.javafx` the situation is trivial on JDKs that bundle JavaFX/OpenJFX. In these cases the JDK provides the OpenJFX classes, which is detected by the module system and the token `org.openide.modules.jre.JavaFX` is automatically provided. On other JDKs OpenJFX is loaded from a set of `org.netbeans.libs.javafx.<PLATFORM>` modules onto the classpath and these modules provide the mentioned token.
Before this change `libs.javafx` had this manifest entry:
```
OpenIDE-Module-Package-Dependencies: javafx.application[Application]
```
With the improved checking this requirement fails on JDK not bundling JavaFX/OpenJFX. For these cases both the fragment host `org.netbeans.libs.javafx` and one of the provider modules, for example `org.netbeans.libs.javafx.linux` would need to be loaded together to be able to satisfy the dependency.
This PR removed the package dependency as it provides no additonal value, as the presence of the token `org.openide.modules.jre.JavaFX` reports presense of native support.
Testing:
--------
To test whether the JavaFX runtime worked I used the embedded webkit browser. It needs to be chosen in the options and can then be opened via `Window` -> `Web` -> `Web Browser`. It will load the Apache NetBeans site. If that loads properly, you are looking at the webkit rendering.
To test whether the JDK bundled JavaFX is correctly detected I removed the `org.netbeans.libs.javafx.linux` module from the installation directory and ran with `ant tryme`. The Ubuntu OpenJDK distribution does not bundle OpenJFX, so WebKit should not work and indeed it did not. The plugin was listed as deactivated in the plugin manager and could not be activated. Then I downloaded Zulu 8 and 17 with bundled OpenJFX. Looking at the structure of 8 it seems to match the old style bundling, so that should match experience on Oracle JDK. With both Zulu variants (running `ant -Dnbjdk.home=$HOME/bin/jdk-17-zulu-openjfx tryme ` and `ant -Dnbjdk.home=$HOME/bin/jdk-8-zulu-openjfx tryme`) the embedded WebKit browser worked and the embedded browser plugin was active.
I rebuild and tested with `org.netbeans.libs.javafx.linux` present. With Ubuntu OpenJDK, Amazon Corretto 11 and Amazon Corretto 17 I got the expected warning:
```
WARNING [javafx]: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @3890968'
```
with Zulu with OpenJFX 8 + 17 I got not warnings. This indicates, that on JDKs were it is required the classpath loading works and on JDKs, that don't need it it is correctly not done.
Closes: #6004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #6010: On JDKs without JavaFX/OpenFX libs.javafx has unsatisfiable package dependency
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6010:
URL: https://github.com/apache/netbeans/pull/6010#issuecomment-1574144345
PR is green. I'll merge on sunday if noone intervenes till then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #6010: On JDKs without JavaFX/OpenFX libs.javafx has unsatisfiable package dependency
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #6010:
URL: https://github.com/apache/netbeans/pull/6010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #6010: On JDKs without JavaFX/OpenFX libs.javafx has unsatisfiable package dependency
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #6010:
URL: https://github.com/apache/netbeans/pull/6010#issuecomment-1572705726
Perfect !! I didn't notice this fixed token provided by the core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists