You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/08/12 16:58:15 UTC
[jira] Closed: (THRIFT-718) Thrift PHP library includes closing
tags and extraneous whitespace
[ https://issues.apache.org/jira/browse/THRIFT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-718.
--------------------------------
Assignee: Nicholas Telford
Fix Version/s: 0.4
Resolution: Fixed
I fixed the newlines at EOF and committed this patch. Thanks Nick!
> Thrift PHP library includes closing tags and extraneous whitespace
> ------------------------------------------------------------------
>
> Key: THRIFT-718
> URL: https://issues.apache.org/jira/browse/THRIFT-718
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: Nicholas Telford
> Assignee: Nicholas Telford
> Fix For: 0.4
>
> Attachments: thrift_php_closingTags.diff, thrift_php_closingTags2.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Extraneous whitespace after a PHP script's closing tag (?>) can cause big problems when sending headers to the client.
> It is generally advised that closing PHP tags be omitted from the end of a PHP file to prevent extraneous whitespace being an issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.