You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/05 19:02:50 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich opened a new pull request, #8: Update package and conf to pekko
mdedetrich opened a new pull request, #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8
Updates package names to `org.apache.pekko` and configuration to `pekko`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
I had to add this implementation because originally this project used an older version of akka-projection which didn't have this method in the interface.
On the other hand the the latest akka BSL version of akka-persistence (and hence current pekko-persistence) has this method which has to be implemented.
I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118.
I don't know if this is correct or not, but its not any worse than pekko-persistence-jdbc which I think is used much more often. @nvollmar @danischroeter @He-Pin @jrudolph @raboof @spangaer @pjfanning Maybe you have some idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
I had to add this implementation because originally this project used an older version of akka-projection which didn't have this method in the interface.
On the other hand the the latest akka BSL version of akka-persistence (and hence current pekko-persistence) has this method in the interface which is forcing me to implement it.
I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118 and hence just reuse the already existing `deleteObject(persistenceId: String)`
I don't know if this is correct or not, but its not any worse than pekko-persistence-jdbc which I think is used much more often. @nvollmar @danischroeter @He-Pin @jrudolph @raboof @spangaer @pjfanning Maybe you have some idea/can comment on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich merged pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
I had to add this implementation because originally this project used an older version of akka-projection which didn't have this method in the interface.
On the other hand the the latest akka BSL version of akka-persistence (and hence current pekko-persistence) has this method which has to be implemented.
I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118.
I don't know if this is correct or not, but its not any worse than pekko-persistence-jdbc which I think is used much more often. @nvollmar @danischroeter @He-Pin @jrudolph @raboof @spangaer Maybe you have some idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158952238
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
Okay in that case then PR is ready to be reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
I had to add this implementation because the originally this project used an older version of akka-projection which didn't have this method in their interface.
On the other hand the the latest akka BSL version of akka-persistence (and hence pekko-persistence) has this method which has to be implemented.
I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
I had to add this implementation because originally this project used an older version of akka-projection which didn't have this method in the interface.
On the other hand the the latest akka BSL version of akka-persistence (and hence current pekko-persistence) has this method in the interface which is forcing me to implement it.
I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118 and hence just reuse the already existing `deleteObject(persistenceId: String)`
I don't know if this is correct or not, but its not any worse than pekko-persistence-jdbc which I think is used much more often. @nvollmar @danischroeter @He-Pin @jrudolph @raboof @spangaer @pjfanning Maybe you have some idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning commented on a diff in pull request #8: Update package and conf to pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158944754
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
override def deleteObject(persistenceId: String): CompletionStage[Done] =
scalaStore.deleteObject(persistenceId).toJava
+ override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =
Review Comment:
this is fine - we've got similar changes in the other pekko-persistence-* projects - we should consider supporting the revision flag but we could do this later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org