You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/06/04 17:24:54 UTC

Review Request 22235: Add support for auth proxy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22235/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Tom Beerbower.


Bugs: AMBARI-5960
    https://issues.apache.org/jira/browse/AMBARI-5960


Repository: ambari


Description
-------

Ambari already had support for proxy port and proxy host, but not when the proxy requires auth.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 0527db1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java ea2062a 

Diff: https://reviews.apache.org/r/22235/diff/


Testing
-------

Manual testing against a deployed cluster with a proxy, and added new unit test.  Results:


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:09.291s
[INFO] Finished at: Wed Jun 04 11:12:58 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 22235: Add support for auth proxy

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22235/#review44716
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 4, 2014, 3:24 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22235/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 3:24 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5960
>     https://issues.apache.org/jira/browse/AMBARI-5960
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari already had support for proxy port and proxy host, but not when the proxy requires auth.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 0527db1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java ea2062a 
> 
> Diff: https://reviews.apache.org/r/22235/diff/
> 
> 
> Testing
> -------
> 
> Manual testing against a deployed cluster with a proxy, and added new unit test.  Results:
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:09.291s
> [INFO] Finished at: Wed Jun 04 11:12:58 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>