You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2015/10/17 01:13:36 UTC
Review Request 39411: Increase timeout and improve assertion message
in ProcessStreamReaderTestCase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39411/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Bugs: GEODE-103
https://issues.apache.org/jira/browse/GEODE-103
Repository: geode
Description
-------
Increase timeout from 30 seconds to 60 seconds for asserting that the process eventually starts.
Improve the assertion message to include the timeout in milliseconds.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java 0b26d33
Diff: https://reviews.apache.org/r/39411/diff/
Testing
-------
BlockingProcessStreamReaderJUnitTest
NonBlockingProcessStreamReaderJUnitTest
Thanks,
Kirk Lund
Re: Review Request 39411: Increase timeout and improve assertion
message in ProcessStreamReaderTestCase
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39411/#review103004
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Oct. 16, 2015, 4:13 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39411/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 4:13 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Bugs: GEODE-103
> https://issues.apache.org/jira/browse/GEODE-103
>
>
> Repository: geode
>
>
> Description
> -------
>
> Increase timeout from 30 seconds to 60 seconds for asserting that the process eventually starts.
>
> Improve the assertion message to include the timeout in milliseconds.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java 0b26d33
>
> Diff: https://reviews.apache.org/r/39411/diff/
>
>
> Testing
> -------
>
> BlockingProcessStreamReaderJUnitTest
> NonBlockingProcessStreamReaderJUnitTest
>
>
> Thanks,
>
> Kirk Lund
>
>