You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/19 05:25:57 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1128: Increase blocking timeout to harden the blocking pop test case
git-hulk opened a new pull request, #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128
Currently, the blocking pop with the empty argument may fail if took a long time(more than 1s) to execute the RPUSH command. The leading cause is the previous BRPOP command would get the empty bulk string(`$-1\r\n`) instead of the element array when it's timed out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128#issuecomment-1320912049
How about introduce some mutex? like `map(key -> mutex)`. (After a cursory glance)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128#issuecomment-1320814086
https://github.com/apache/incubator-kvrocks/actions/runs/3502202012/jobs/5866498105#step:12:209
Looks like the bug was caused by the blocking client wasn't wake up after pushing the new element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128#issuecomment-1320807058
I think 4 seconds is long enough since the default read/write timeout of the Redis client is 3 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128#issuecomment-1320814198
> https://github.com/apache/incubator-kvrocks/actions/runs/3502202012/jobs/5866498105#step:12:209
>
> Looks like the bug was caused by the blocking client wasn't wake up after pushing the new element and then response nil bulk string after timeout reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128#issuecomment-1328009710
Merging as a net win...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #1128: Increase blocking timeout to harden the blocking pop test case
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #1128:
URL: https://github.com/apache/incubator-kvrocks/pull/1128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org