[jira] [Commented] (JCLOUDS-752) Add error-prone to the build and create bug patterns for known bugs or anti-patterns.

["Andrew Phillips (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168700#comment-14168700 ] 

Andrew Phillips commented on JCLOUDS-752:
-----------------------------------------

If we have any initial apprehensions about this, how about the following: we can put the plugin in a profile, enable that profile in our CI builds and describe how users can enable the profile by default on their local machines if they like. We can also easily exclude it from any Java 8 builds then (or even stick that in the activation section of the profile).

If we find that this helps more than in hurts, we can easily enable it by default?

> Add error-prone to the build and create bug patterns for known bugs or anti-patterns.
> -------------------------------------------------------------------------------------
>
>                 Key: JCLOUDS-752
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-752
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-core
>            Reporter: Adrian Cole
>
> We have bug patterns that regularly happen due to programming mistakes
>  * Having a fallback to null, but no nullable
>  * putting fallback with mismatching return type (ex. null on boolean)
>  * forgetting to add Named (which is used for timeout config)
> ...
> There's an existing tool, which was first published to maven central in may 2012 and has had regular releases since, and contributions by several people: Error prone
> error-prone allows you to use existing bug patterns or create new ones that can help you identify bugs.
> https://code.google.com/p/error-prone/wiki/BugPatterns
> I'm aware that we already have checkstyle and modernizer in the build, and [~gaul] is apprehensive about adding this. He mentioned a preference to run it manually, and cited some concern about it not working with JDK 8 some time ago.
> Instead of finding reasons not to use this tool, or limiting its effectiveness to manual runs (which would allow new bugs to creep in), I highly encourage us to be as fair with adding this as we were with adding other tools like checkstyle and modernizer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)