[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2960: Fix take string on sliced indices

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2960:
URL: https://github.com/apache/arrow-rs/pull/2960#discussion_r1007470264


##########
arrow-select/src/take.rs:
##########
@@ -675,12 +673,7 @@ where
             *offset = length_so_far;
         }
 
-        nulls = match indices.data_ref().null_buffer() {
-            Some(buffer) => {
-                Some(buffer_bin_and(buffer, 0, &null_buf.into(), 0, data_len))

Review Comment:
   The bug is that this doesn't take into account any offset that indices may have.
   
   However, this code is completely redundant as we already check the validity of indices when constructing this mask, and so we can just remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org