[GitHub] [helix] Marcosrico commented on a diff in pull request #2208: Unnecessary log removal

[GitBox <gi...@apache.org>]

Marcosrico commented on code in PR #2208:
URL: https://github.com/apache/helix/pull/2208#discussion_r970928059


##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -277,10 +277,7 @@ private Response batchGetStoppableInstances(String clusterId, JsonNode node, boo
           .error(String.format("Current cluster %s has issue with health checks!", clusterId), e);
       throw new HelixHealthException(e);
     } catch (Exception e) {
-      _logger.error(String.format(
-              "Failed to get parallel stoppable instances for cluster %s with a HelixException!",
-              clusterId), e);
-      throw e;
+      throw new Exception("Failed to get parallel stoppable instances for cluster " + clusterId + " with a HelixException!", e);

Review Comment:
   Not sure I understand. Is throwing a new Exception with `e` passed in as arguments not the same time as exception `e` by itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org