You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/06 20:33:22 UTC

Re: Review Request 23772: Re-enable HealthCheckTest.ConsecutiveFailures test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23772/#review49770
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 30, 2014, 9:14 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23772/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-1613
>     https://issues.apache.org/jira/browse/MESOS-1613
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Re-enable HealthCheckTest.ConsecutiveFailures test.
> The test originally was flaky because the time to process the number of consecutive checks configured exceeds the task itself, so the task finished but the number of expected task health check didn't match.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 6c54ea8 
> 
> Diff: https://reviews.apache.org/r/23772/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>