You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/01 07:06:34 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
LuciferYang opened a new pull request, #38860:
URL: https://github.com/apache/spark/pull/38860
### What changes were proposed in this pull request?
This pr aims to refactor `UnsafeArrayWriterSuite` to check `TOO_MANY_ARRAY_ELEMENTS`.
### Why are the changes needed?
Test should check error class
### Does this PR introduce _any_ user-facing change?
No, just for test
### How was this patch tested?
Pass GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38860:
URL: https://github.com/apache/spark/pull/38860#issuecomment-1333305337
cc @MaxGekk a minor refactor for existing test to test `TOO_MANY_ARRAY_ELEMENTS `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
URL: https://github.com/apache/spark/pull/38860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38860:
URL: https://github.com/apache/spark/pull/38860#issuecomment-1333640526
+1, LGTM. Merging to master.
Thank you, @LuciferYang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38860: [SPARK-41348][SQL][TESTS] Refactor `UnsafeArrayWriterSuite` to check error class
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38860:
URL: https://github.com/apache/spark/pull/38860#issuecomment-1333645356
thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org