You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2024/10/25 12:23:36 UTC
[PR] MINOR: add limitation doc for controller membership change [kafka]
showuon opened a new pull request, #17598:
URL: https://github.com/apache/kafka/pull/17598
Add limitation doc for controller membership change
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add limitation doc for controller membership change [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #17598:
URL: https://github.com/apache/kafka/pull/17598#issuecomment-2441438720
@fvaleri @cmccabe , thanks for the comment/update. All LGTM. I added one example to show the failed `--feature kraft.version=1` case in [this commit](https://github.com/apache/kafka/pull/17598/commits/a10040b7c8a95927508597e26157232c5b1b9975). Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve doc for controller membership change [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #17598:
URL: https://github.com/apache/kafka/pull/17598#discussion_r1822013806
##########
docs/ops.html:
##########
@@ -3876,8 +3876,8 @@ <h5 class="anchor-heading"><a id="static_versus_dynamic_kraft_quorums" class="an
Cannot set kraft.version to 1 unless KIP-853 configuration is present. Try removing the --feature flag for kraft.version.
</code></pre><p>
- In a future release, it will be possible to convert clusters using a static controller quorum to
- use a dynamic controller quorum. However, this is not currently possible.<p>
+ Note: Currently it is <b>not</b> possible to convert clusters using a static controller quorum to
+ use a dynamic controller quorum. This function will be supported in the future release.
Review Comment:
Made it much clear to mention current limitation. The semantic is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add limitation doc for controller membership change [kafka]
Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #17598:
URL: https://github.com/apache/kafka/pull/17598#discussion_r1816620981
##########
docs/ops.html:
##########
@@ -3823,6 +3823,10 @@ <h5 class="anchor-heading"><a id="kraft_storage_observers" class="anchor-link"><
<h4 class="anchor-heading"><a id="kraft_reconfig" class="anchor-link"></a><a href="#kraft_reconfig">Controller membership changes</a></h4>
+ <h5 class="anchor-heading"><a id="kraft_reconfig_limitation" class="anchor-link"></a><a href="#kraft_reconfig_limitation">Limitation</a></h5>
+ Currently, the controller membership change is only supported for new created KRaft cluster, which formatting the controllers with the above ways.
+ For cluster upgraded from older version, it is not able to do controller membership change. Additionally, the metrics related to membership change are also not implemented, yet.
Review Comment:
```suggestion
Currently, controller membership changes are only supported for newly created KRaft clusters formatted with the specified methods.
Clusters upgraded from older versions cannot perform controller membership changes. Furthermore, metrics related to membership changes are not yet implemented.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add limitation doc for controller membership change [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #17598:
URL: https://github.com/apache/kafka/pull/17598#issuecomment-2437643879
@cmccabe @jsancio , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve doc for controller membership change [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe merged PR #17598:
URL: https://github.com/apache/kafka/pull/17598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org