You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/07 08:31:31 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r331897407
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -62,75 +68,53 @@ class PodGenerator:
     Contains Kubernetes Airflow Worker configuration logic
 
     Represents a kubernetes pod and manages execution of a single pod.
-    :param image: The docker image
 
 Review comment:
   The issue is that the type annotations do not (currently) show up in the docs, so we need to  :(
   
   As part of a separate PR https://pypi.org/project/sphinx-autodoc-typehints/ might help

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services