[GitHub] [pulsar-client-node] RobertIndie commented on a diff in pull request #250: Supoort prebuild macos-arm64 arch binaries.

[GitBox <gi...@apache.org>]

RobertIndie commented on code in PR #250:
URL: https://github.com/apache/pulsar-client-node/pull/250#discussion_r1036655600


##########
.github/workflows/ci-build-release-napi.yml:
##########
@@ -38,16 +38,24 @@ jobs:
           path: pkg/mac/build
           key: ${{ runner.os }}-${{ matrix.arch }}-mac-${{ hashFiles('pkg/mac/build-cpp-deps-lib.sh') }}
 
+      - name: Add arch env vars
+        run: |
+          if [ "${{ matrix.arch }}" = "x64" ]; then
+            echo "ARCH=x86_64" >> $GITHUB_ENV
+          else
+            echo "ARCH=${{ matrix.target }}" >> $GITHUB_ENV

Review Comment:
   What is `matrix.target` referred to here?



##########
.github/workflows/ci-build-release-napi.yml:
##########
@@ -57,6 +65,7 @@ jobs:
           npx node-pre-gyp build --target_arch=${{ matrix.arch }}
 
       - name: Test loading Node binaries lib
+        if: matrix.arch == 'x64'

Review Comment:
   Why do you skip `arm64` here? I saw that it's empty from CI: https://github.com/apache/pulsar-client-node/actions/runs/3561255235/jobs/5981995900#step:5:5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org