[GitHub] [superset] jfrag1 commented on a diff in pull request #23729: chore: migrate `sqllab_viz` endpoint to api v1

["jfrag1 (via GitHub)" <gi...@apache.org>]

jfrag1 commented on code in PR #23729:
URL: https://github.com/apache/superset/pull/23729#discussion_r1172826084


##########
superset/datasets/api.py:
##########
@@ -989,3 +1001,120 @@ def get_or_create_dataset(self) -> Response:
                 exc_info=True,
             )
             return self.response_422(message=ex.message)
+
+    @expose("/sqllab_viz/", methods=["POST"])

Review Comment:
   Instead of creating a new endpoint, could we instead re-use the `POST /api/v1/dataset/` endpoint?  It seems to serve the same purpose and has the validation being done in this endpoint automatically built-in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org