You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/10/05 23:40:28 UTC
Review Request 39020: GEODE-244: Fixing race in
testRecoverRedundancyWithOfflinePersistenceSimulation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39020/
-----------------------------------------------------------
Review request for geode and Ashvin A.
Repository: geode
Description
-------
The test recreates the persistent partitioned region, and then asserts
that all buckets are recovered. But the buckets may be recovered
asynchronously. Now the test will wait for the buckets to show up.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java 1b04ecb3fface8031108fd9655ae752e0a78e9b4
Diff: https://reviews.apache.org/r/39020/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 39020: GEODE-244: Fixing race in
testRecoverRedundancyWithOfflinePersistenceSimulation
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39020/#review101605
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On Oct. 5, 2015, 9:40 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39020/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 9:40 p.m.)
>
>
> Review request for geode and Ashvin A.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test recreates the persistent partitioned region, and then asserts
> that all buckets are recovered. But the buckets may be recovered
> asynchronously. Now the test will wait for the buckets to show up.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java 1b04ecb3fface8031108fd9655ae752e0a78e9b4
>
> Diff: https://reviews.apache.org/r/39020/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 39020: GEODE-244: Fixing race in
testRecoverRedundancyWithOfflinePersistenceSimulation
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39020/#review101537
-----------------------------------------------------------
Ship it!
Ship It!
- Ashvin A
On Oct. 5, 2015, 9:40 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39020/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 9:40 p.m.)
>
>
> Review request for geode and Ashvin A.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test recreates the persistent partitioned region, and then asserts
> that all buckets are recovered. But the buckets may be recovered
> asynchronously. Now the test will wait for the buckets to show up.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java 1b04ecb3fface8031108fd9655ae752e0a78e9b4
>
> Diff: https://reviews.apache.org/r/39020/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>