You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/08 09:49:02 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #10701: [reafactor](predicate) refactor predicates in scan node
Gabriel39 opened a new pull request, #10701:
URL: https://github.com/apache/doris/pull/10701
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10701: [refactor](predicate) refactor predicates in scan node
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10701:
URL: https://github.com/apache/doris/pull/10701#discussion_r916809110
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -937,7 +944,7 @@ std::pair<bool, void*> VOlapScanNode::should_push_down_eq_predicate(doris::SlotD
return result_pair;
}
-template <typename T, typename ChangeFixedValueRangeFunc>
+template <PrimitiveType T, typename ChangeFixedValueRangeFunc>
Status VOlapScanNode::change_fixed_value_range(ColumnValueRange<T>& temp_range, PrimitiveType type,
void* value, const ChangeFixedValueRangeFunc& func) {
Review Comment:
Does `T` always equal to `type`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10701: [refactor](predicate) refactor predicates in scan node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10701:
URL: https://github.com/apache/doris/pull/10701#issuecomment-1179486376
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10701: [refactor](predicate) refactor predicates in scan node
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10701:
URL: https://github.com/apache/doris/pull/10701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on a diff in pull request #10701: [reafactor](predicate) refactor predicates in scan node
Posted by GitBox <gi...@apache.org>.
mrhhsg commented on code in PR #10701:
URL: https://github.com/apache/doris/pull/10701#discussion_r916669902
##########
be/src/exec/olap_common.h:
##########
@@ -44,25 +45,26 @@ std::string cast_to_string(int8_t);
/**
* @brief Column's value range
**/
-template <class T>
+template <doris::PrimitiveType primitive_type>
class ColumnValueRange {
public:
- typedef typename std::set<T>::iterator iterator_type;
+ using CppType = typename doris::PrimitiveTypeTraits<primitive_type>::CppType;
+ using IteratorType = typename std::set<CppType>::iterator;
ColumnValueRange();
- ColumnValueRange(std::string col_name, PrimitiveType type);
+ ColumnValueRange(std::string col_name, doris::PrimitiveType type);
- ColumnValueRange(std::string col_name, PrimitiveType type, const T& min, const T& max,
- bool contain_null);
+ ColumnValueRange(std::string col_name, doris::PrimitiveType type, const CppType& min,
Review Comment:
Maybe we can remove the arg `type` because it is the same as the template arg `doris::PrimitiveType primitive_type`?
##########
be/src/exec/olap_common.cpp:
##########
@@ -42,17 +42,32 @@ std::string cast_to_string(int8_t value) {
}
template <>
-void ColumnValueRange<StringValue>::convert_to_fixed_value() {
+void ColumnValueRange<doris::PrimitiveType::TYPE_STRING>::convert_to_fixed_value() {
Review Comment:
namespace `doris` is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10701: [refactor](predicate) refactor predicates in scan node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10701:
URL: https://github.com/apache/doris/pull/10701#issuecomment-1179486374
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org