You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Matt Baldwin <no...@github.com> on 2015/02/10 23:06:14 UTC
[jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Snapshots
API (#134)
Hi All:
Here's a pull request to surface the snapshot capabilities within jClouds Labs for the ProfitBricks provider. We are working in conjunction with @devcsrj . Please let us know if there are any questions or issues.
Thanks.
-matt
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/134
-- Commit Summary --
* JCLOUDS-702: JCloud ProfitBricks provider implementation
* Merge remote-tracking branch 'upstream/master'
* Image Api
* Server api
* Merge branch 'master' of github.com:jclouds/jclouds-labs
* Addressed review comments
* Tests for asserting correct request body
* Storage api
* Improved error handler for html response
* Storage API live tests
* Snapshot infrastructure
* added unit test for snapshot request builder
* Added unit test for Snapshot Request builder
* Added Snapshot Mock Tests
* Added update and delete Snapshot implementation and mock tests.
* Snapshot Rollback
* Added live tests
* Snapshot Create fix
* Code clean up
* Tweaks for PR
* Revert "Tweaks for PR"
* Removed the comments
* Code reviewed
* Fix
* Merge remote-tracking branch 'upstream/snapshot-api' into snapshot-api
* Merge remote-tracking branch 'upstream/snapshot-api' into snapshot-api
* ProvisioningStatusPollingPredicate, SnapshotApiLiveTest, BaseProfitBricksLiveTest - added snapshotWaitingPredicate
* Fixed comment text
* Minor code clean up
* Removed @Test annotation on testDeleteSnapshot
* Removed println
-- File Changes --
A profitbricks/output.txt (2)
M profitbricks/src/main/java/org/jclouds/profitbricks/ProfitBricksApi.java (83)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/BaseProfitBricksRequestBinder.java (150)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/server/CreateServerRequestBinder.java (114)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/server/UpdateServerRequestBinder.java (112)
A profitbricks/src/main/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinder.java (44)
A profitbricks/src/main/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestHandler.java (42)
A profitbricks/src/main/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinder.java (53)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/storage/ConnectStorageToServerRequestBinder.java (90)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/storage/CreateStorageRequestBinder.java (92)
M profitbricks/src/main/java/org/jclouds/profitbricks/binder/storage/UpdateStorageRequestBinder.java (94)
M profitbricks/src/main/java/org/jclouds/profitbricks/compute/internal/ProvisioningStatusAware.java (5)
M profitbricks/src/main/java/org/jclouds/profitbricks/compute/internal/ProvisioningStatusPollingPredicate.java (120)
M profitbricks/src/main/java/org/jclouds/profitbricks/domain/AvailabilityZone.java (70)
M profitbricks/src/main/java/org/jclouds/profitbricks/domain/DataCenter.java (323)
M profitbricks/src/main/java/org/jclouds/profitbricks/domain/OsType.java (60)
M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Server.java (884)
A profitbricks/src/main/java/org/jclouds/profitbricks/domain/Snapshot.java (432)
M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Storage.java (710)
M profitbricks/src/main/java/org/jclouds/profitbricks/features/ServerApi.java (328)
A profitbricks/src/main/java/org/jclouds/profitbricks/features/SnapshotApi.java (90)
M profitbricks/src/main/java/org/jclouds/profitbricks/features/StorageApi.java (272)
M profitbricks/src/main/java/org/jclouds/profitbricks/handlers/ProfitBricksHttpErrorHandler.java (150)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorService.java (280)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/BaseProfitBricksResponseHandler.java (128)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/RequestIdOnlyResponseHandler.java (90)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandler.java (116)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/datacenter/BaseDataCenterResponseHandler.java (76)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterInfoResponseHandler.java (228)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterListResponseHandler.java (122)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/image/BaseImageResponseHandler.java (142)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandler.java (88)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandler.java (98)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/BaseServerResponseHandler.java (172)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerIdOnlyResponseHandler.java (102)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerInfoResponseHandler.java (96)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandler.java (102)
A profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/snapshot/BaseSnapshotResponseHandler.java (70)
A profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/snapshot/SnapshotListResponseHandler.java (48)
A profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/snapshot/SnapshotResponseHandler.java (45)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/state/GetProvisioningStateResponseHandler.java (94)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/BaseStorageResponseHandler.java (166)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/StorageIdOnlyResponseHandler.java (92)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/StorageInfoResponseHandler.java (100)
M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/storage/StorageListResponseHandler.java (108)
M profitbricks/src/test/java/org/jclouds/profitbricks/BaseProfitBricksLiveTest.java (27)
M profitbricks/src/test/java/org/jclouds/profitbricks/binder/server/CreateServerRequestBinderTest.java (130)
M profitbricks/src/test/java/org/jclouds/profitbricks/binder/server/UpdateServerRequestBinderTest.java (128)
A profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java (50)
A profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java (59)
M profitbricks/src/test/java/org/jclouds/profitbricks/binder/storage/ConnectStorageToServerRequestBinderTest.java (110)
M profitbricks/src/test/java/org/jclouds/profitbricks/binder/storage/CreateStorageRequestBinderTest.java (112)
M profitbricks/src/test/java/org/jclouds/profitbricks/binder/storage/UpdateStorageRequestBinderTest.java (106)
M profitbricks/src/test/java/org/jclouds/profitbricks/domain/ServerBuilderTest.java (324)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/DataCenterApiMockTest.java (542)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/ImageApiMockTest.java (232)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/ServerApiLiveTest.java (278)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/ServerApiMockTest.java (726)
A profitbricks/src/test/java/org/jclouds/profitbricks/features/SnapshotApiLiveTest.java (158)
A profitbricks/src/test/java/org/jclouds/profitbricks/features/SnapshotApiMockTest.java (263)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/StorageApiLiveTest.java (334)
M profitbricks/src/test/java/org/jclouds/profitbricks/features/StorageApiMockTest.java (570)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorServiceTest.java (286)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/RequestIdOnlyResponseHandlerTest.java (152)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ServiceFaultResponseHandlerTest.java (98)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterInfoResponseHandlerTest.java (196)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageInfoResponseHandlerTest.java (130)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/image/ImageListResponseHandlerTest.java (366)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerIdOnlyResponseHandlerTest.java (80)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerInfoResponseHandlerTest.java (154)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandlerTest.java (194)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/storage/StorageIdOnlyResponseHandlerTest.java (84)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/storage/StorageInfoResponseHandlerTest.java (132)
M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/storage/StorageListResponseHandlerTest.java (160)
M profitbricks/src/test/java/org/jclouds/profitbricks/internal/BaseProfitBricksMockTest.java (208)
A profitbricks/src/test/resources/snapshot/snapshot-create.xml (11)
A profitbricks/src/test/resources/snapshot/snapshot-delete.xml (10)
A profitbricks/src/test/resources/snapshot/snapshot-rollback.xml (12)
A profitbricks/src/test/resources/snapshot/snapshot-update.xml (10)
A profitbricks/src/test/resources/snapshot/snapshot.xml (27)
A profitbricks/src/test/resources/snapshot/snapshots.xml (47)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/134.patch
https://github.com/jclouds/jclouds-labs/pull/134.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by Matt Baldwin <no...@github.com>.
@nacx Hi, we've been working on this with RJ. We have the PR passing tests so we're just waiting on a review to merge. Let me know if there are any issues or changes that need to happen. Thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74518044
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by Matt Baldwin <no...@github.com>.
@nacx We're forked from a fork. We're going to re-do our repo, the branch, and then re-send a new PR with meeting hopefully your requirements. We're not sure how to clean it up otherwise. This is work we're doing in tandem with another user.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74910315
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by Matt Baldwin <no...@github.com>.
Closed #134.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#event-237827778
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by Ignasi Barrera <no...@github.com>.
I think the starting point of this PR is not the right one, as I see some merge commits there too. If you have a look at the modified files in the PR, you will see *many* files that are not related to the changes for the SnapshotApi. There is the entire pom.xml that appears as changed, the ServerApi and so on.
Please, clean the pull request in a way that it **only** cointains the relevant changes and the relevant commits (the PR has 50 commits right now most of them unrelated to the changes). Otherwise it will be difficult to review, but more important, we won't know how to merge it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74903223
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by Ignasi Barrera <no...@github.com>.
This PR includes code that is already in master, and it is quite hard to review. Can you please rebase it to the latest master version?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74840815
Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider -
Snapshots API (#134)
Posted by jasminSPC <no...@github.com>.
@nacx I've just rebased to the latest master version.
Did I miss anything?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/134#issuecomment-74895426