You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "xx789633 (via GitHub)" <gi...@apache.org> on 2025/08/22 13:19:40 UTC

[PR] [lake/iceberg] add full data type integration test [fluss]

xx789633 opened a new pull request, #1577:
URL: https://github.com/apache/fluss/pull/1577

   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/alibaba/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #1574 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "xx789633 (via GitHub)" <gi...@apache.org>.
xx789633 commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2297218697


##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int bucketNum) throws Exceptio
                 TableDescriptor.builder()
                         .schema(
                                 Schema.newBuilder()
-                                        .column("a", DataTypes.INT())
-                                        .column("b", DataTypes.STRING())
-                                        .primaryKey("a")
+                                        .column("f_boolean", DataTypes.BOOLEAN())
+                                        .column("f_byte", DataTypes.TINYINT())
+                                        .column("f_short", DataTypes.SMALLINT())
+                                        .column("f_int", DataTypes.INT())
+                                        .column("f_long", DataTypes.BIGINT())
+                                        .column("f_float", DataTypes.FLOAT())
+                                        .column("f_double", DataTypes.DOUBLE())
+                                        .column("f_string", DataTypes.STRING())
+                                        .column("f_decimal1", DataTypes.DECIMAL(5, 2))
+                                        .column("f_decimal2", DataTypes.DECIMAL(20, 0))
+                                        .column("f_timestamp_ltz1", DataTypes.TIMESTAMP_LTZ(3))
+                                        .column("f_timestamp_ltz2", DataTypes.TIMESTAMP_LTZ(6))
+                                        .column("f_timestamp_ntz1", DataTypes.TIMESTAMP(3))
+                                        .column("f_timestamp_ntz2", DataTypes.TIMESTAMP(6))
+                                        .column("f_binary", DataTypes.BINARY(4))

Review Comment:
   Hi @MehulBatra @luoyuxia thanks for the reminder. More data types have been added. Please take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on PR #1577:
URL: https://github.com/apache/fluss/pull/1577#issuecomment-3219291886

   Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2296793357


##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int bucketNum) throws Exceptio
                 TableDescriptor.builder()
                         .schema(
                                 Schema.newBuilder()
-                                        .column("a", DataTypes.INT())
-                                        .column("b", DataTypes.STRING())
-                                        .primaryKey("a")
+                                        .column("f_boolean", DataTypes.BOOLEAN())
+                                        .column("f_byte", DataTypes.TINYINT())
+                                        .column("f_short", DataTypes.SMALLINT())
+                                        .column("f_int", DataTypes.INT())
+                                        .column("f_long", DataTypes.BIGINT())
+                                        .column("f_float", DataTypes.FLOAT())
+                                        .column("f_double", DataTypes.DOUBLE())
+                                        .column("f_string", DataTypes.STRING())
+                                        .column("f_decimal1", DataTypes.DECIMAL(5, 2))
+                                        .column("f_decimal2", DataTypes.DECIMAL(20, 0))
+                                        .column("f_timestamp_ltz1", DataTypes.TIMESTAMP_LTZ(3))
+                                        .column("f_timestamp_ltz2", DataTypes.TIMESTAMP_LTZ(6))
+                                        .column("f_timestamp_ntz1", DataTypes.TIMESTAMP(3))
+                                        .column("f_timestamp_ntz2", DataTypes.TIMESTAMP(6))
+                                        .column("f_binary", DataTypes.BINARY(4))

Review Comment:
   We should include them aswell as we have them covered in `FlussDataTypeToIcebergDataType` class, what do you think?
   ```
    .column("f_char", DataTypes.CHAR(4))
    .column("f_bytes", DataTypes.BYTES())         
    .column("f_date", DataTypes.DATE())          
    .column("f_time", DataTypes.TIME())       
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2297008228


##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int bucketNum) throws Exceptio
                 TableDescriptor.builder()
                         .schema(
                                 Schema.newBuilder()
-                                        .column("a", DataTypes.INT())
-                                        .column("b", DataTypes.STRING())
-                                        .primaryKey("a")
+                                        .column("f_boolean", DataTypes.BOOLEAN())
+                                        .column("f_byte", DataTypes.TINYINT())
+                                        .column("f_short", DataTypes.SMALLINT())
+                                        .column("f_int", DataTypes.INT())
+                                        .column("f_long", DataTypes.BIGINT())
+                                        .column("f_float", DataTypes.FLOAT())
+                                        .column("f_double", DataTypes.DOUBLE())
+                                        .column("f_string", DataTypes.STRING())
+                                        .column("f_decimal1", DataTypes.DECIMAL(5, 2))
+                                        .column("f_decimal2", DataTypes.DECIMAL(20, 0))
+                                        .column("f_timestamp_ltz1", DataTypes.TIMESTAMP_LTZ(3))
+                                        .column("f_timestamp_ltz2", DataTypes.TIMESTAMP_LTZ(6))
+                                        .column("f_timestamp_ntz1", DataTypes.TIMESTAMP(3))
+                                        .column("f_timestamp_ntz2", DataTypes.TIMESTAMP(6))
+                                        .column("f_binary", DataTypes.BINARY(4))

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2296793357


##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int bucketNum) throws Exceptio
                 TableDescriptor.builder()
                         .schema(
                                 Schema.newBuilder()
-                                        .column("a", DataTypes.INT())
-                                        .column("b", DataTypes.STRING())
-                                        .primaryKey("a")
+                                        .column("f_boolean", DataTypes.BOOLEAN())
+                                        .column("f_byte", DataTypes.TINYINT())
+                                        .column("f_short", DataTypes.SMALLINT())
+                                        .column("f_int", DataTypes.INT())
+                                        .column("f_long", DataTypes.BIGINT())
+                                        .column("f_float", DataTypes.FLOAT())
+                                        .column("f_double", DataTypes.DOUBLE())
+                                        .column("f_string", DataTypes.STRING())
+                                        .column("f_decimal1", DataTypes.DECIMAL(5, 2))
+                                        .column("f_decimal2", DataTypes.DECIMAL(20, 0))
+                                        .column("f_timestamp_ltz1", DataTypes.TIMESTAMP_LTZ(3))
+                                        .column("f_timestamp_ltz2", DataTypes.TIMESTAMP_LTZ(6))
+                                        .column("f_timestamp_ntz1", DataTypes.TIMESTAMP(3))
+                                        .column("f_timestamp_ntz2", DataTypes.TIMESTAMP(6))
+                                        .column("f_binary", DataTypes.BINARY(4))

Review Comment:
   We should include them aswell as we have them covered in `FlussRecordAsIcebergRecord` class, what do you think?
   ```
    .column("f_char", DataTypes.CHAR(4))
    .column("f_bytes", DataTypes.BYTES())         
    .column("f_date", DataTypes.DATE())          
    .column("f_time", DataTypes.TIME())       
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra merged PR #1577:
URL: https://github.com/apache/fluss/pull/1577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on PR #1577:
URL: https://github.com/apache/fluss/pull/1577#issuecomment-3219290619

   @luoyuxia LGTM aswell!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2296794611


##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int bucketNum) throws Exceptio
                 TableDescriptor.builder()
                         .schema(
                                 Schema.newBuilder()
-                                        .column("a", DataTypes.INT())
-                                        .column("b", DataTypes.STRING())
-                                        .primaryKey("a")
+                                        .column("f_boolean", DataTypes.BOOLEAN())
+                                        .column("f_byte", DataTypes.TINYINT())
+                                        .column("f_short", DataTypes.SMALLINT())
+                                        .column("f_int", DataTypes.INT())
+                                        .column("f_long", DataTypes.BIGINT())
+                                        .column("f_float", DataTypes.FLOAT())
+                                        .column("f_double", DataTypes.DOUBLE())
+                                        .column("f_string", DataTypes.STRING())
+                                        .column("f_decimal1", DataTypes.DECIMAL(5, 2))
+                                        .column("f_decimal2", DataTypes.DECIMAL(20, 0))
+                                        .column("f_timestamp_ltz1", DataTypes.TIMESTAMP_LTZ(3))
+                                        .column("f_timestamp_ltz2", DataTypes.TIMESTAMP_LTZ(6))
+                                        .column("f_timestamp_ntz1", DataTypes.TIMESTAMP(3))
+                                        .column("f_timestamp_ntz2", DataTypes.TIMESTAMP(6))
+                                        .column("f_binary", DataTypes.BINARY(4))

Review Comment:
   To support this we might need changes in the `FlussRecordAsIcebergRecord` class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [lake/iceberg] add full data type integration test [fluss]

Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on PR #1577:
URL: https://github.com/apache/fluss/pull/1577#issuecomment-3218355699

   Thank you for the great work! left small comment PTAL, rest looks good to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org