You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cs...@apache.org on 2020/03/11 10:49:24 UTC
[activemq] branch master updated: AMQ-7301 - TransportConnector
errors should log the root cause
This is an automated email from the ASF dual-hosted git repository.
cshannon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git
The following commit(s) were added to refs/heads/master by this push:
new ee61ed6 AMQ-7301 - TransportConnector errors should log the root cause
ee61ed6 is described below
commit ee61ed69f8ca7ea116014a981225f446d0a05d8a
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
AuthorDate: Wed Mar 11 06:47:35 2020 -0400
AMQ-7301 - TransportConnector errors should log the root cause
(cherry picked from commit 57a1a77abb54e6862d61626d9a2985b84b9975a9)
---
.../main/java/org/apache/activemq/broker/TransportConnector.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnector.java b/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnector.java
index 1008285..e68d6f6 100644
--- a/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnector.java
+++ b/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnector.java
@@ -26,6 +26,7 @@ import java.util.regex.Pattern;
import javax.management.ObjectName;
+import com.google.common.base.Throwables;
import org.apache.activemq.broker.jmx.ManagedTransportConnector;
import org.apache.activemq.broker.jmx.ManagementContext;
import org.apache.activemq.broker.region.ConnectorStatistics;
@@ -241,11 +242,9 @@ public class TransportConnector implements Connector, BrokerServiceAware {
if (brokerService != null && brokerService.isStopping()) {
LOG.info("Could not accept connection during shutdown {} : {}", (remoteHost == null ? "" : "from " + remoteHost), error.getLocalizedMessage());
} else {
- LOG.debug("Could not accept connection from {}: {}", remoteHost, error.getMessage());
+ LOG.warn("Could not accept connection from {}: {}", (remoteHost == null ? "" : "from " + remoteHost), error.getMessage());
+ LOG.warn("Root cause of connection error: {}", Throwables.getRootCause(error).getMessage());
LOG.debug("Reason: " + error.getMessage(), error);
- if (error != null && error.getMessage() != null && remoteHost != null) {
- LOG.warn("Could not accept connection from {}: {}", remoteHost, error.toString());
- }
}
}
});