You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@asterixdb.apache.org by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/08/15 16:39:50 UTC

Change in asterixdb[master]: [ASTERIXDB-2042][CLUS] Shutdown NC on Startup Completion Fai...

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1943

Change subject: [ASTERIXDB-2042][CLUS] Shutdown NC on Startup Completion Failure
......................................................................

[ASTERIXDB-2042][CLUS] Shutdown NC on Startup Completion Failure

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Report runtime exceptions of NC startup completion to CC.
- Shutdown NC after reporting startup completion failure.

Change-Id: I6c2ff0130e5e3e35ccf42a66d6855e568dce1fbe
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/message/StartupTaskResponseMessage.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1943/1

diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/message/StartupTaskResponseMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/message/StartupTaskResponseMessage.java
index aaf3eb8..93a03fd 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/message/StartupTaskResponseMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/message/StartupTaskResponseMessage.java
@@ -29,6 +29,7 @@
 import org.apache.asterix.common.replication.INCLifecycleMessage;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 import org.apache.hyracks.api.service.IControllerService;
+import org.apache.hyracks.control.nc.NCShutdownHook;
 
 public class StartupTaskResponseMessage implements INCLifecycleMessage, INcAddressedMessage {
 
@@ -52,9 +53,9 @@
             for (INCLifecycleTask task : tasks) {
                 task.perform(cs);
             }
-        } catch (HyracksDataException e) {
+        } catch (Throwable e) { //NOSONAR all startup failures should be reported to CC
             success = false;
-            exception = e;
+            exception = HyracksDataException.create(e);
         }
         NCLifecycleTaskReportMessage result = new NCLifecycleTaskReportMessage(nodeId, success);
         result.setException(exception);
@@ -64,6 +65,10 @@
             LOGGER.log(Level.SEVERE, "Failed sending message to cc", e);
             throw HyracksDataException.create(e);
         }
+        if (!success) {
+            // stop NC so that it can be started again
+            Runtime.getRuntime().exit(NCShutdownHook.FAILED_TO_STARTUP_EXIT_CODE);
+        }
     }
 
     public String getNodeId() {
diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
index 4d0c159..162d912 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
@@ -27,6 +27,8 @@
  * operation is hanging for any reason
  */
 public class NCShutdownHook extends Thread {
+
+    public static final int FAILED_TO_STARTUP_EXIT_CODE = 2;
     private static final Logger LOGGER = Logger.getLogger(NCShutdownHook.class.getName());
     private static final long SHUTDOWN_WAIT_TIME = 10 * 60 * 1000L;
     private final Thread watchDog;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1943
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c2ff0130e5e3e35ccf42a66d6855e568dce1fbe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>