You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/05/17 17:08:45 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #196: feat(r): Add ability to deterministically run a finalizer on an array stream
paleolimbot opened a new pull request, #196:
URL: https://github.com/apache/arrow-nanoarrow/pull/196
Before, the finalizer would only run on garbage collection. For ADBC, we want that to be deterministic so that we can close a statement/connection predictably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #196: feat(r): Add ability to deterministically run a finalizer on an array stream
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #196:
URL: https://github.com/apache/arrow-nanoarrow/pull/196#issuecomment-1551778568
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#196](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b63c654) into [main](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/f559d59aaa031111a07c8c163163205c60899ee0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f559d59) will **decrease** coverage by `0.10%`.
> The diff coverage is `54.16%`.
```diff
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 88.30% 88.21% -0.10%
==========================================
Files 60 60
Lines 8981 9005 +24
==========================================
+ Hits 7931 7944 +13
- Misses 1050 1061 +11
```
| [Impacted Files](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [r/R/array-stream.R](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9SL2FycmF5LXN0cmVhbS5S) | `86.95% <0.00%> (-8.29%)` | :arrow_down: |
| [r/src/array\_stream.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXJyYXlfc3RyZWFtLmg=) | `88.23% <ø> (ø)` | |
| [r/src/util.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvdXRpbC5o) | `100.00% <ø> (ø)` | |
| [r/src/array\_stream.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXJyYXlfc3RyZWFtLmM=) | `82.29% <54.54%> (-3.60%)` | :arrow_down: |
| [r/src/nanoarrow\_cpp.cc](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvbmFub2Fycm93X2NwcC5jYw==) | `95.83% <100.00%> (+0.27%)` | :arrow_up: |
| [r/src/pointers.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvcG9pbnRlcnMuYw==) | `93.98% <100.00%> (+0.18%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #196: feat(r): Add ability to deterministically run a finalizer on an array stream
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #196:
URL: https://github.com/apache/arrow-nanoarrow/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org