[GitHub] [airflow] phanikumv commented on a diff in pull request #31548: Add credential configuration file support to Google Cloud Hook

["phanikumv (via GitHub)" <gi...@apache.org>]

phanikumv commented on code in PR #31548:
URL: https://github.com/apache/airflow/pull/31548#discussion_r1205772273


##########
airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -311,9 +315,20 @@ def _get_credentials_using_key_secret_name(self):
         project_id = credentials.project_id
         return credentials, project_id
 
+    def _get_credentials_using_credential_config_file(self):

Review Comment:
   can we add unit tests for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org