You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/17 00:50:47 UTC
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15614: [doc][config]Add missing transaction config in standalone.conf and broker.conf
Anonymitaet commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874263945
##########
conf/broker.conf:
##########
@@ -1395,7 +1395,7 @@ fileSystemURI=
transactionCoordinatorEnabled=false
transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider
-# Transaction buffer take snapshot transaction count
+# Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.
Review Comment:
```suggestion
# Transaction buffer takes a snapshot after the number of transaction operations reaches this value.
```
1. Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp
2. Why capitalize B for buffer?
##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
|replicationProducerQueueSize| Replicator producer queue size |1000|
|replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl ||
|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds. |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |true|
-|transactionMetadataStoreProviderClassName| |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
Review Comment:
The description is missing
##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
|replicationProducerQueueSize| Replicator producer queue size |1000|
|replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl ||
|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds. |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |true|
-|transactionMetadataStoreProviderClassName| |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|Transaction buffer take snapshot interval time (Unit : millisecond)|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. It stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes|500|
Review Comment:
who `stores the position in pendingAckStore as its value and saves a position ....`? can you specify it explicitly?
##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
|replicationProducerQueueSize| Replicator producer queue size |1000|
|replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl ||
|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds. |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |true|
-|transactionMetadataStoreProviderClassName| |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker. |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|Transaction buffer take snapshot interval time (Unit : millisecond)|5000|
Review Comment:
```suggestion
|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds)|5000|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org