You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jacob Brookover <jb...@cast.org> on 2011/06/15 16:55:42 UTC
Wicket Stuff commit access jbrookover
Hello,
I'm quite new to Git, but I've made various changes to the 'tinymce' module and would like to push those changes to GitHub. Those changes include..
- Updating to a later version of TinyMCE
- A fix that allows lazy loading of dependencies during an AJAX rendering of TinyMCE
- Updating to some newer plugins (e.g. autoresize)
- Fix for a rendering bug that would fail to re-render a TinyMCE instance through an AJAX Call (e.g. when form validation fails)
Also open to any and all oversight and advice during my first Git push - took me several tries to get it figured out in Eclipse. Always used SVN up to this point :)
Thanks!
Jake Brookover
GitHub: jbrookover
Re: Wicket Stuff commit access jbrookover
Posted by Michael O'Cleirigh <mi...@rivulet.ca>.
Added.
If you want feedback before pushing I would suggest registering a pull
request from your fork like this describes:
http://help.github.com/send-pull-requests
Then other wicketstuff devs can comment before the changes are merged in.
Regards,
Mike
> Hello,
>
> I'm quite new to Git, but I've made various changes to the 'tinymce' module and would like to push those changes to GitHub. Those changes include..
>
> - Updating to a later version of TinyMCE
> - A fix that allows lazy loading of dependencies during an AJAX rendering of TinyMCE
> - Updating to some newer plugins (e.g. autoresize)
> - Fix for a rendering bug that would fail to re-render a TinyMCE instance through an AJAX Call (e.g. when form validation fails)
>
> Also open to any and all oversight and advice during my first Git push - took me several tries to get it figured out in Eclipse. Always used SVN up to this point :)
>
> Thanks!
>
> Jake Brookover
> GitHub: jbrookover
Re: Wicket Stuff commit access jbrookover
Posted by Martin Grigorov <mg...@apache.org>.
Done
On Wed, Jun 15, 2011 at 6:38 PM, Alexander Morozov
<al...@gmail.com> wrote:
> Martin,
>
> could you grant commit access for me too :) ? I think it will be more
> productive,
> if I could open pull request instead of pushing patches to other GITHUB
> project (https://github.com/wicketstuff/core/issues/32). I would like to
> make some contributions to inmethod-grid project, such as fix javascript
> rendering in case of AJAX, fix NoRecordsToolbar and NavigationToolbar in
> case of data grid with unknown item count if there is no data returned by
> datasource.
>
> github user: shuraa
>
> Thanks
>
>
> -----
> --
> http://www.linkedin.com/in/amorozov
> --
> View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-Stuff-commit-access-jbrookover-tp3599608p3599722.html
> Sent from the Forum for Wicket Core developers mailing list archive at Nabble.com.
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: Wicket Stuff commit access jbrookover
Posted by Alexander Morozov <al...@gmail.com>.
Martin,
could you grant commit access for me too :) ? I think it will be more
productive,
if I could open pull request instead of pushing patches to other GITHUB
project (https://github.com/wicketstuff/core/issues/32). I would like to
make some contributions to inmethod-grid project, such as fix javascript
rendering in case of AJAX, fix NoRecordsToolbar and NavigationToolbar in
case of data grid with unknown item count if there is no data returned by
datasource.
github user: shuraa
Thanks
-----
--
http://www.linkedin.com/in/amorozov
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-Stuff-commit-access-jbrookover-tp3599608p3599722.html
Sent from the Forum for Wicket Core developers mailing list archive at Nabble.com.
Re: Wicket Stuff commit access jbrookover
Posted by Martin Grigorov <mg...@apache.org>.
Welcome!
Added!
On Wed, Jun 15, 2011 at 5:55 PM, Jacob Brookover <jb...@cast.org> wrote:
> Hello,
>
> I'm quite new to Git, but I've made various changes to the 'tinymce' module and would like to push those changes to GitHub. Those changes include..
>
> - Updating to a later version of TinyMCE
> - A fix that allows lazy loading of dependencies during an AJAX rendering of TinyMCE
> - Updating to some newer plugins (e.g. autoresize)
> - Fix for a rendering bug that would fail to re-render a TinyMCE instance through an AJAX Call (e.g. when form validation fails)
>
> Also open to any and all oversight and advice during my first Git push - took me several tries to get it figured out in Eclipse. Always used SVN up to this point :)
>
> Thanks!
>
> Jake Brookover
> GitHub: jbrookover
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com