You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 00:13:34 UTC
[GitHub] [airflow] kaxil opened a new pull request #15556: Add ``serve-logs`` CLI command to serve logs
kaxil opened a new pull request #15556:
URL: https://github.com/apache/airflow/pull/15556
Currently, the `serve_logs` endpoint only exists on Celery workers. This
means if someone launches Airflow with the `LocalExecutor` and wants to
grab the logs from the scheduler, there is no way to move that to the
webserver if it is on a different pod/machine.
closes https://github.com/apache/airflow/pull/15070
closes https://github.com/apache/airflow/issues/13331
closes https://github.com/apache/airflow/issues/15071
closes https://github.com/apache/airflow/issues/14222
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #15556:
URL: https://github.com/apache/airflow/pull/15556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #15556:
URL: https://github.com/apache/airflow/pull/15556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15556:
URL: https://github.com/apache/airflow/pull/15556#issuecomment-829316376
Closing in favor of https://github.com/apache/airflow/pull/15557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15556:
URL: https://github.com/apache/airflow/pull/15556#issuecomment-828078000
Alternative approach: https://github.com/apache/airflow/pull/15557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15556:
URL: https://github.com/apache/airflow/pull/15556#issuecomment-828567086
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #15556: Add ``serve-logs`` CLI command to serve logs
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #15556:
URL: https://github.com/apache/airflow/pull/15556#issuecomment-828078000
Alternative approach: https://github.com/apache/airflow/pull/15557 where we automatically serve logs for Scheduler when using Local or Sequential Executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org