[jira] Commented: (HARMONY-5587) [jdktools][jdwp6] Add new command ConstantPool Command for Java 6

["Ivan Popov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577344#action_12577344 ] 

Ivan Popov commented on HARMONY-5587:
-------------------------------------

Please be careful copy-pasting code for new command, don't forget to change trace messages correspondingly. For example, with this path the new command ConstantPoolHandler will be reported as SourceDebugExtension in trace messages:

+void
+ReferenceType::ConstantPoolHandler::Execute(JNIEnv *jni)
+        throw (AgentException)
+{
+    jclass jvmClass = m_cmdParser->command.ReadReferenceTypeID(jni);
+    // Can be: InternalErrorException, OutOfMemoryException,
+    // JDWP_ERROR_INVALID_CLASS, JDWP_ERROR_INVALID_OBJECT
+#ifndef NDEBUG
+    if (JDWP_TRACE_ENABLED(LOG_KIND_DATA)) {
+        jvmtiError err;
+        char* signature = 0;
+        JVMTI_TRACE(err, GetJvmtiEnv()->GetClassSignature(jvmClass, &signature, 0));
+        JvmtiAutoFree afcs(signature);
+        JDWP_TRACE_DATA("SourceDebugExtension: received: refTypeID=" << jvmClass
+            << ", classSignature=" << JDWP_CHECK_NULL(signature));
+    }
+#endif


> [jdktools][jdwp6] Add new command ConstantPool Command for Java 6
> -----------------------------------------------------------------
>
>                 Key: HARMONY-5587
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5587
>             Project: Harmony
>          Issue Type: New Feature
>          Components: JDK
>            Reporter: Sean Qiu
>            Assignee: Jimmy, Jing Lv
>         Attachments: Harmony-5587.zip
>
>
> Implement ConstantPool Command for JDWP of Java 6.
> This command returns the raw bytes of the constant pool in the format of the constant_pool item of the Class File Format in the Java Virtual Machine Specification. 
> The spec does not specify the content details of constant pool in runtime.
> It may be changed between different VM implementations.
> The current test is based on the behavior of RI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.