You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2017/02/07 22:15:45 UTC
Review Request 56407: Upgrade: Package Install stuck in "Installing"
state forever
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor Magyari, and Sid Wagle.
Bugs: AMBARI-19904
https://issues.apache.org/jira/browse/AMBARI-19904
Repository: ambari
Description
-------
When a command fails the all the other pending commands that belong to the same request are aborted. In order the cluster state to be correctly reflected the cluster state has to be recalculated for each aborted command from all stages of the request.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8aef70d
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a
Diff: https://reviews.apache.org/r/56407/diff/
Testing
-------
Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent.
Unit testing:
mvn test -DskipPythonTests -am -pl ambari-server
Results :
Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
Thanks,
Sebastian Toader
Re: Review Request 56407: Upgrade: Package Install stuck in
"Installing" state forever
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164660
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Feb. 8, 2017, 10:08 a.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56407/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 10:08 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor Magyari, and Sid Wagle.
>
>
> Bugs: AMBARI-19904
> https://issues.apache.org/jira/browse/AMBARI-19904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a command fails the all the other pending commands that belong to the same request are aborted. In order the cluster state to be correctly reflected the cluster state has to be recalculated for each aborted command from all stages of the request.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8aef70d
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a
>
> Diff: https://reviews.apache.org/r/56407/diff/
>
>
> Testing
> -------
>
> Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent.
>
> Unit testing:
> mvn test -DskipPythonTests -am -pl ambari-server
>
> Results :
>
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 56407: Upgrade: Package Install stuck in
"Installing" state forever
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164697
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On \u041b\u044e\u0442. 8, 2017, 12:08 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56407/
> -----------------------------------------------------------
>
> (Updated \u041b\u044e\u0442. 8, 2017, 12:08 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor Magyari, and Sid Wagle.
>
>
> Bugs: AMBARI-19904
> https://issues.apache.org/jira/browse/AMBARI-19904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a command fails the all the other pending commands that belong to the same request are aborted. In order the cluster state to be correctly reflected the cluster state has to be recalculated for each aborted command from all stages of the request.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8aef70d
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a
>
> Diff: https://reviews.apache.org/r/56407/diff/
>
>
> Testing
> -------
>
> Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent.
>
> Unit testing:
> mvn test -DskipPythonTests -am -pl ambari-server
>
> Results :
>
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 56407: Upgrade: Package Install stuck in
"Installing" state forever
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 11:08 a.m.)
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor Magyari, and Sid Wagle.
Bugs: AMBARI-19904
https://issues.apache.org/jira/browse/AMBARI-19904
Repository: ambari
Description
-------
When a command fails the all the other pending commands that belong to the same request are aborted. In order the cluster state to be correctly reflected the cluster state has to be recalculated for each aborted command from all stages of the request.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8aef70d
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a
Diff: https://reviews.apache.org/r/56407/diff/
Testing
-------
Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent.
Unit testing:
mvn test -DskipPythonTests -am -pl ambari-server
Results :
Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
Thanks,
Sebastian Toader
Re: Review Request 56407: Upgrade: Package Install stuck in
"Installing" state forever
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164633
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java (line 229)
<https://reviews.apache.org/r/56407/#comment236401>
Shouldn't this be `commands = hostRoleCommandDAO.mergeAll(commands);` to reflect the managed entities?
- Attila Doroszlai
On Feb. 7, 2017, 11:15 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56407/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:15 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor Magyari, and Sid Wagle.
>
>
> Bugs: AMBARI-19904
> https://issues.apache.org/jira/browse/AMBARI-19904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a command fails the all the other pending commands that belong to the same request are aborted. In order the cluster state to be correctly reflected the cluster state has to be recalculated for each aborted command from all stages of the request.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8aef70d
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a
>
> Diff: https://reviews.apache.org/r/56407/diff/
>
>
> Testing
> -------
>
> Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent.
>
> Unit testing:
> mvn test -DskipPythonTests -am -pl ambari-server
>
> Results :
>
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
>
>
> Thanks,
>
> Sebastian Toader
>
>