You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2015/10/22 01:05:03 UTC

Re: logging-log4j2 git commit: Fix test to match code change.

Thank you! I was sloppy. 

Sent from my iPhone

> On 2015/10/22, at 5:12, ggregory@apache.org wrote:
> 
> Repository: logging-log4j2
> Updated Branches:
>  refs/heads/master 0eb6ddfbf -> 3da6c31db
> 
> 
> Fix test to match code change.
> 
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/3da6c31d
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/3da6c31d
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/3da6c31d
> 
> Branch: refs/heads/master
> Commit: 3da6c31dbe096a1967f32b12c4ef3e93704da963
> Parents: 0eb6ddf
> Author: ggregory <gg...@apache.org>
> Authored: Wed Oct 21 13:11:49 2015 -0700
> Committer: ggregory <gg...@apache.org>
> Committed: Wed Oct 21 13:11:49 2015 -0700
> 
> ----------------------------------------------------------------------
> .../logging/log4j/core/async/AsyncLoggerContextSelectorTest.java   | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3da6c31d/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> ----------------------------------------------------------------------
> diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> index dc60aab..3bae290 100644
> --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> @@ -54,7 +54,7 @@ public class AsyncLoggerContextSelectorTest {
>     public void testContextNameIsAsyncLoggerContextWithClassHashCode() {
>         final AsyncLoggerContextSelector selector = new AsyncLoggerContextSelector();
>         final LoggerContext context = selector.getContext(null, null, false);
> -        final String expectedContextName = "AsyncLoggerContext@" + AsyncLoggerContext.class.hashCode();
> +        final String expectedContextName = "AsyncLoggerContext@" + Integer.toHexString(AsyncLoggerContext.class.hashCode());
>         assertEquals(expectedContextName, context.getName());
>     }
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Re: logging-log4j2 git commit: Fix test to match code change.

Posted by Gary Gregory <ga...@gmail.com>.
YW ;-)

On Wed, Oct 21, 2015 at 4:05 PM, Remko Popma <re...@gmail.com> wrote:

> Thank you! I was sloppy.
>
> Sent from my iPhone
>
> > On 2015/10/22, at 5:12, ggregory@apache.org wrote:
> >
> > Repository: logging-log4j2
> > Updated Branches:
> >  refs/heads/master 0eb6ddfbf -> 3da6c31db
> >
> >
> > Fix test to match code change.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/3da6c31d
> > Tree:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/3da6c31d
> > Diff:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/3da6c31d
> >
> > Branch: refs/heads/master
> > Commit: 3da6c31dbe096a1967f32b12c4ef3e93704da963
> > Parents: 0eb6ddf
> > Author: ggregory <gg...@apache.org>
> > Authored: Wed Oct 21 13:11:49 2015 -0700
> > Committer: ggregory <gg...@apache.org>
> > Committed: Wed Oct 21 13:11:49 2015 -0700
> >
> > ----------------------------------------------------------------------
> > .../logging/log4j/core/async/AsyncLoggerContextSelectorTest.java   | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3da6c31d/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> > ----------------------------------------------------------------------
> > diff --git
> a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> > index dc60aab..3bae290 100644
> > ---
> a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> > +++
> b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerContextSelectorTest.java
> > @@ -54,7 +54,7 @@ public class AsyncLoggerContextSelectorTest {
> >     public void testContextNameIsAsyncLoggerContextWithClassHashCode() {
> >         final AsyncLoggerContextSelector selector = new
> AsyncLoggerContextSelector();
> >         final LoggerContext context = selector.getContext(null, null,
> false);
> > -        final String expectedContextName = "AsyncLoggerContext@" +
> AsyncLoggerContext.class.hashCode();
> > +        final String expectedContextName = "AsyncLoggerContext@" +
> Integer.toHexString(AsyncLoggerContext.class.hashCode());
> >         assertEquals(expectedContextName, context.getName());
> >     }
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory