You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/12/02 20:02:03 UTC

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #2115: SOLR-14992 Wait for node down before checking for node up

tflobbe commented on a change in pull request #2115:
URL: https://github.com/apache/lucene-solr/pull/2115#discussion_r534445545



##########
File path: solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java
##########
@@ -236,8 +237,9 @@ public void testCloseHooksDeletedOnReconnect() throws Exception {
     JettySolrRunner jetty = getJettyForReplica(s.getReplicas(EnumSet.of(Replica.Type.PULL)).get(0));
     SolrCore core = jetty.getCoreContainer().getCores().iterator().next();
 
-    for (int i = 0; i < 5; i++) {
+    for (int i = 0; i < (TEST_NIGHTLY ? 5 : 2); i++) {
       cluster.expireZkSession(jetty);
+      waitForState("Expecting node to be disconnected", collectionName, activeReplicaCount(1, 0, 0));

Review comment:
       Wouldn't it be better to actually check for the node znode `ctime`? Or maybe a bump in `/live_nodes`'s `cversion`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org