You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/05/11 02:57:59 UTC

[GitHub] [incubator-devlake] keon94 opened a new pull request, #5155: [feat-4762] part2: Rework scope_helper for compatiblity with Python

keon94 opened a new pull request, #5155:
URL: https://github.com/apache/incubator-devlake/pull/5155

   ### Summary
   What does this PR do?
   
   ### Does this close any open issues?
   Part of #4762 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5155: [feat-4762] part2: Rework scope_helper for compatiblity with Python

Posted by "keon94 (via GitHub)" <gi...@apache.org>.

keon94 commented on code in PR #5155:
URL: https://github.com/apache/incubator-devlake/pull/5155#discussion_r1192776339


##########
backend/helpers/pluginhelper/api/scope_helper.go:
##########
@@ -18,98 +18,59 @@ limitations under the License.
 package api

Review Comment:
   most of this logic has moved to scope_generic_helper.go



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on pull request #5155: [feat-4762] part2: Rework scope_helper for compatiblity with Python

Posted by "klesh (via GitHub)" <gi...@apache.org>.

klesh commented on PR #5155:
URL: https://github.com/apache/incubator-devlake/pull/5155#issuecomment-1549292956

   I'm not familiar with the python plugins, @CamilleTeruel would be a more suitable reviewer than me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] hezyin merged pull request #5155: [feat-4762] part2: Rework scope_helper for compatiblity with Python

Posted by "hezyin (via GitHub)" <gi...@apache.org>.

hezyin merged PR #5155:
URL: https://github.com/apache/incubator-devlake/pull/5155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org