[GitHub] [solr] vinayakphegde commented on pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

["vinayakphegde (via GitHub)" <gi...@apache.org>]

vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1493249446

   > You forgot [Uwe's comment](https://issues.apache.org/jira/browse/SOLR-16642?focusedCommentId=17683095&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17683095) out reverting the `--enable-preview`. I'll do this now.
   > 
   > I'll also throw UOE as I suggested in this review.
   
   thanks @dsmiley for working on @uschindler comment
    
   > Can you comment on why org.apache.solr.update.processor.UpdateRequestProcessor#extractTypedNamedEntities needed to be updated? Did the API change and you just updated it to comply with the change? It's not apparently purely looking at the PR.
   > 
   > I'll add a CHANGES.txt as well and probably merge Monday.
   
   that is no longer needed, we are handling the exception in between. will change it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org