You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Pierre Smits <pi...@apache.org> on 2022/01/27 14:55:28 UTC

Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)

Jacques,

It is of lesser importance of from when it dated or who provided the code
improvement and who merged it in the codebase. What is more important how
many hulrdles are brought into play to get it improved.


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*

Anyone could have been you, whereas I've always been anyone.


On Thu, Jan 27, 2022 at 3:21 PM GitBox <gi...@apache.org> wrote:

>
> JacquesLeRoux edited a comment on pull request #466:
> URL:
> https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
>
>
>    > <field name="partyId" title="Employee Name"
>
>    That's indeed wrong in any cases (in RecruitmentForms.xml), and dates
> from Jira OFBIZ-2205
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>

Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 27/01/2022 à 15:57, Pierre Smits a écrit :
> Playing the 'blame' game is detrimental to the success of the project, and
> thus to all using, contributing, making a living with...

Hi Pierre,

It seems you don't understand why I put "is broken by" references from and in Jiras and GH. It's not at all to play the "blame game".

It to actually allow us to better understand what is happening from where in the past that can be useful in the future.

OFBIZ-7024 and OFBIZ-5341 are related examples that helped me in the task for OFBIZ-12548 that was eventually 
https://github.com/apache/ofbiz-framework/commit/7562476e1e7c6cf6bac2be96c74fcc2bf754a58d

HTH

Jacques


Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)

Posted by Pierre Smits <pi...@apache.org>.
Playing the 'blame' game is detrimental to the success of the project, and
thus to all using, contributing, making a living with...
Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*

Anyone could have been you, whereas I've always been anyone.


On Thu, Jan 27, 2022 at 3:55 PM Pierre Smits <pi...@apache.org> wrote:

> Jacques,
>
> It is of lesser importance of from when it dated or who provided the code
> improvement and who merged it in the codebase. What is more important how
> many hulrdles are brought into play to get it improved.
>
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
> 2008 (without privileges)
> Proud contributor to the ASF since 2006
> *Apache Directory <https://directory.apache.org>, PMC Member*
>
> Anyone could have been you, whereas I've always been anyone.
>
>
> On Thu, Jan 27, 2022 at 3:21 PM GitBox <gi...@apache.org> wrote:
>
>>
>> JacquesLeRoux edited a comment on pull request #466:
>> URL:
>> https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
>>
>>
>>    > <field name="partyId" title="Employee Name"
>>
>>    That's indeed wrong in any cases (in RecruitmentForms.xml), and dates
>> from Jira OFBIZ-2205
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>>