You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/12/28 16:55:57 UTC
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1294
Implement a NSX API request execution counter per thread
The NSX plugin has a execution counter to prevent infinite recursion (and as a result a stack overflow exception). However, the thread safeness of this counter are not as desired. The counter was implemented with an AtomicInteger which make it safe for multiple threads to update and read it. The desired property would be to have a counter per thread.
This PR addresses that issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguelaferreira/cloudstack nsx-execution-counter-per-thread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1294
----
commit 40501518b7fbb71fc138a12fdf2d31a56d822619
Author: Miguel Ferreira <mi...@me.com>
Date: 2015-12-17T15:29:59Z
Add test to check that each thread has it's own execution counter
commit 7f332d760bc824664f41133eeb694fae0f57f5f3
Author: Miguel Ferreira <mi...@me.com>
Date: 2015-12-17T18:47:08Z
Fix execution counter to support separate counts per thread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172460540
@remibergsma @DaanHoogland I've fixed a concurency issue in a unit tests (pointed out by @borisroman) and in the process rebased this branch on latest 4.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055
LGTM :+1:
Did code review and ran the PR in beta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172247247
Haven't seen the issue in our production cloud since we run with this fix. Thanks! LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172309823
@borisroman said he had an improvement to the unit test. Let's discuss and add it to the PR so we can merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Implement a NSX API request execution cou...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172375026
makes sense @miguelaferreira . I have no use to this but I think it needs to go in
LGTM @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---