[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1465: [CELEBORN-559][BUG] createReader should also wait for retry when change to same peer

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1465:
URL: https://github.com/apache/incubator-celeborn/pull/1465#discussion_r1178022825


##########
client/src/main/java/org/apache/celeborn/client/read/RssInputStream.java:
##########
@@ -223,12 +223,19 @@ private void moveToNextReader() throws IOException {
     }
 
     private PartitionReader createReaderWithRetry(PartitionLocation location) throws IOException {
+      PartitionLocation lastPeer = location;
       while (fetchChunkRetryCnt < fetchChunkMaxRetry) {
         try {
           return createReader(location, fetchChunkRetryCnt, fetchChunkMaxRetry);
         } catch (Exception e) {
           fetchChunkRetryCnt++;

Review Comment:
   Now every turn or no peer need sleep retryWaitMs otherwise try peer directly, if coding this way would clear than before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org