You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/04/29 16:12:05 UTC
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2250
[HOTFIX] Fix lucene match limit code
Problem
Currently, Lucene match limit is set as Static in `MatchExpression` it cannot work in concurrent scenarios.
Solution:
Change to object variable and get the match max limit from expression.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata lucene-matchlimit-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2250
----
commit 32eb738f50b53c76ce95630278ae86216bf4223a
Author: ravipesala <ra...@...>
Date: 2018-04-29T15:19:18Z
Fix lucene match limit code
----
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4508/
---
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2250#discussion_r185177377
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/MatchExpression.java ---
@@ -29,15 +29,19 @@
@InterfaceAudience.Internal
public class MatchExpression extends Expression {
private String queryString;
- public static String maxDoc;
+ private String maxDoc;
--- End diff --
I think better to use int
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5662/
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2250
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4619/
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5517/
---
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2250#discussion_r186266536
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/MatchExpression.java ---
@@ -29,15 +29,19 @@
@InterfaceAudience.Internal
public class MatchExpression extends Expression {
private String queryString;
- public static String maxDoc;
+ private String maxDoc;
--- End diff --
ok
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4353/
---
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2250#discussion_r185723052
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/MatchExpression.java ---
@@ -29,15 +29,19 @@
@InterfaceAudience.Internal
public class MatchExpression extends Expression {
private String queryString;
- public static String maxDoc;
+ private String maxDoc;
+
+ public MatchExpression(String queryString) {
+ this.queryString = queryString;
+ }
public MatchExpression(String queryString, String maxDoc) {
this.queryString = queryString;
- setMaxDoc(maxDoc);
+ this.maxDoc = maxDoc;
--- End diff --
validate the maxDoc parameter here and convert it to int
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2250
retest this please
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2250
LGTM
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4502/
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2250
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4743/
---
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2250
---
[GitHub] carbondata issue #2250: [HOTFIX] Fix lucene match limit code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2250
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5668/
---
[GitHub] carbondata pull request #2250: [HOTFIX] Fix lucene match limit code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2250#discussion_r186266538
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/MatchExpression.java ---
@@ -29,15 +29,19 @@
@InterfaceAudience.Internal
public class MatchExpression extends Expression {
private String queryString;
- public static String maxDoc;
+ private String maxDoc;
+
+ public MatchExpression(String queryString) {
+ this.queryString = queryString;
+ }
public MatchExpression(String queryString, String maxDoc) {
this.queryString = queryString;
- setMaxDoc(maxDoc);
+ this.maxDoc = maxDoc;
--- End diff --
ok
---