You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/18 04:46:09 UTC

[GitHub] [rocketmq-client-go] WJL3333 opened a new pull request, #812: Fix bug when get `mqadmin consumerStatus` can't get consume status.

WJL3333 opened a new pull request, #812:
URL: https://github.com/apache/rocketmq-client-go/pull/812

   mqadmin consumerStatus command should get consumeRT related metrics. but current code return all 0.0
   
   
   ## Brief changelog
   
   parameter pass to method wrong.
   
   ## Verifying this change
   mqadmin consumerStatus  now show value not 0.0
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] guyinyou commented on pull request #812: Fix bug when get `mqadmin consumerStatus` can't get consume status.

Posted by GitBox <gi...@apache.org>.
guyinyou commented on PR #812:
URL: https://github.com/apache/rocketmq-client-go/pull/812#issuecomment-1101116567

   
   It is recommended to modify this part:
   consumer/statistics.go:113
   consumer/statistics.go:117
   consumer/statistics.go:121
   consumer/statistics.go:129
   consumer/statistics.go:133
   
   like:
   getPullRT(group, topic string) -> getPullRT(toipc, group string)
   
   Because then it can be aligned with the Java version
   ![image](https://user-images.githubusercontent.com/36399867/163761314-22d57889-e398-4b59-a067-4fdcadd60d71.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] ShannonDing merged pull request #812: [ISSUE #813] Fix bug when get `mqadmin consumerStatus` can't get consume status.

Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #812:
URL: https://github.com/apache/rocketmq-client-go/pull/812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org