You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/26 10:16:07 UTC

[GitHub] ralf0131 closed pull request #59: add star icon && optimize for build

ralf0131 closed pull request #59: add star icon && optimize for build
URL: https://github.com/apache/incubator-dubbo-website/pull/59
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/index.html b/index.html
index 5d0c5b5..9947324 100644
--- a/index.html
+++ b/index.html
@@ -8,13 +8,10 @@
 	<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
 	<!-- 网页标签ico -->
 	<link rel="icon" href="./img/dubbo.ico">
-	<link type="text/css" rel="stylesheet" href="./build/page.css" />
 </head>
 
 <body>
 	<div id="root"></div>
-	<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@9.12.0/build/highlight.min.js"></script>
-	<script src="https://cdn.jsdelivr.net/npm/markdown-it@8.3.1/dist/markdown-it.min.js"></script>
 	<script src="https://f.alicdn.com/react/15.4.1/react-with-addons.min.js"></script>
 	<script src="https://f.alicdn.com/react/15.4.1/react-dom.min.js"></script>
 	<script src="https://cdn.jsdelivr.net/npm/react-router-dom@4.2.2/umd/react-router-dom.min.js"></script>
@@ -29,6 +26,7 @@
 
 		gtag('config', 'UA-112489517-1');
 	</script>
+	<script async defer src="https://buttons.github.io/buttons.js"></script>
 </body>
 
 </html>
\ No newline at end of file
diff --git a/src/pages/home/index.jsx b/src/pages/home/index.jsx
index e553193..7bb1066 100644
--- a/src/pages/home/index.jsx
+++ b/src/pages/home/index.jsx
@@ -69,6 +69,9 @@ class Home extends Language {
               <img src="./img/incubating.svg" />
             </div>
             <p className="product-desc">{dataSource.brand.briefIntroduction}</p>
+            <p style={{ marignTop: 20, height: 28 }}>
+              <a className="github-button" href="https://github.com/apache/incubator-dubbo" data-size="large" data-show-count="true" aria-label="Star apache/incubator-dubbo on GitHub">Star</a>
+            </p>
             <div className="button-area">
               <Link className="button" to={dataSource.brand.button.link}>{dataSource.brand.button.text}</Link>
             </div>
diff --git a/webpack.config.js b/webpack.config.js
index 0734b04..d42e76e 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -1,4 +1,3 @@
-const ExtractTextPlugin = require('extract-text-webpack-plugin');
 const path = require('path');
 const webpack = require('webpack');
 
@@ -16,8 +15,6 @@ module.exports = {
   externals: {
     react: 'React',
     'react-dom': 'ReactDOM',
-    'highlight.js': 'hljs',
-    'markdown-it': 'markdownit',
     'react-router-dom': 'ReactRouterDOM',
   },
   module: {
@@ -28,13 +25,8 @@ module.exports = {
         use: 'babel-loader',
       },
       {
-        test: /\.scss$/,
-        loader: ExtractTextPlugin.extract({ fallback: 'style-loader', use: ['raw-loader', 'sass-loader'] }),
-      },
-      {
-        test: /\.css$/,
-        // exclude: /node_modules/,
-        loader: ExtractTextPlugin.extract({ fallback: 'style-loader', use: 'raw-loader' }),
+        test: /\.(s)?css$/,
+        use: ['style-loader', 'raw-loader', 'sass-loader'],
       },
       {
         test: /\.json?$/,
@@ -49,6 +41,5 @@ module.exports = {
   plugins: [
     new webpack.NoEmitOnErrorsPlugin(),
     new webpack.optimize.OccurrenceOrderPlugin(),
-    new ExtractTextPlugin('[name].css')
   ]
 };


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org