You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/14 05:58:53 UTC

[GitHub] [dolphinscheduler] huangchenguang123 opened a new issue, #10962: [bug] [master] task can't use [out] type param

huangchenguang123 opened a new issue, #10962:
URL: https://github.com/apache/dolphinscheduler/issues/10962

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   task can't use [out] type param.
   ![image](https://user-images.githubusercontent.com/37766284/178894470-795336f9-acfc-4cae-b71f-f7c67030f03a.png)
   
   sqlTask use prepareParamsMap to replace param.
   ![image](https://user-images.githubusercontent.com/37766284/178909266-329e0c67-3955-452c-900e-7be3c74ec239.png)
   
   prepareParamsMap uses varPool of parameters.
   ![image](https://user-images.githubusercontent.com/37766284/178909396-a04b55e6-a07f-405d-9a0f-4affaaeb4c9d.png)
   
   parameters's varPool uses taskInstance.taskParams
   ![image](https://user-images.githubusercontent.com/37766284/178909832-74519f7b-a0b0-4225-8e1d-f06f7255847b.png)
   
   BUT prepareParamsMap is created earlier than assignment of taskInstance.taskParams.varpool.
   ![image](https://user-images.githubusercontent.com/37766284/178910179-96612f94-8565-447a-8859-1fa9677d5cac.png)
   
   So taskInstance.taskParams..varpool is always null when prepareParamsMap is created.
   
   ### What you expected to happen
   
   task can use [out] type param
   
   ### How to reproduce
   
   1.create a task with [out] type task
   2.create a sql use it.
   
   
   ### Anything else
   
   none.
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] huangchenguang123 closed issue #10962: [bug] [master] task can't use [out] type param

Posted by GitBox <gi...@apache.org>.
huangchenguang123 closed issue #10962: [bug] [master] task can't use [out] type param
URL: https://github.com/apache/dolphinscheduler/issues/10962


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10962: [bug] [master] task can't use [out] type param

Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10962:
URL: https://github.com/apache/dolphinscheduler/issues/10962#issuecomment-1192278167

   close by #11053 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10962: [bug] [master] task can't use [out] type param

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10962:
URL: https://github.com/apache/dolphinscheduler/issues/10962#issuecomment-1184029418

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10962: [bug] [master] task can't use [out] type param

Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10962:
URL: https://github.com/apache/dolphinscheduler/issues/10962#issuecomment-1192278014

   > Hi @huangchenguang123 #11053 had fixed the out param pass, you can check it again in dev.
   
   Thanks, this is also a way to solve the issue. I will close my issue and pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] caishunfeng commented on issue #10962: [bug] [master] task can't use [out] type param

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #10962:
URL: https://github.com/apache/dolphinscheduler/issues/10962#issuecomment-1189733360

   Hi @huangchenguang123  #11053 had fixed the out param pass, you can check it again in dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org