You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jf...@apache.org on 2013/04/23 22:32:45 UTC

git commit: Thrift-1942: Binary accelerated cpp extension does not use Thrift namespaces for Exceptions Client: php Patch: Tyler Hobbs

Updated Branches:
  refs/heads/master 146e5116a -> 6bdb10b59


Thrift-1942: Binary accelerated cpp extension does not use Thrift namespaces for Exceptions
Client: php
Patch: Tyler Hobbs

Adds namespaced TException to the accelerated php client lib.


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/6bdb10b5
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/6bdb10b5
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/6bdb10b5

Branch: refs/heads/master
Commit: 6bdb10b592853fa036ff656032adb03d4b1a3ef4
Parents: 146e511
Author: jfarrell <jf...@apache.org>
Authored: Tue Apr 23 15:42:04 2013 -0500
Committer: jfarrell <jf...@apache.org>
Committed: Tue Apr 23 15:42:04 2013 -0500

----------------------------------------------------------------------
 .../ext/thrift_protocol/php_thrift_protocol.cpp    |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/6bdb10b5/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
----------------------------------------------------------------------
diff --git a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
index 0d741c2..551d438 100644
--- a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
+++ b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
@@ -423,7 +423,7 @@ void throw_tprotocolexception(char* what, long errorcode) {
 
   zval* ex;
   MAKE_STD_ZVAL(ex);
-  createObject("TProtocolException", ex, 2, zwhat, zerrorcode);
+  createObject("\\Thrift\\Exception\\TProtocolException", ex, 2, zwhat, zerrorcode);
   zval_ptr_dtor(&zwhat);
   zval_ptr_dtor(&zerrorcode);
   throw PHPExceptionWrapper(ex);
@@ -1101,7 +1101,7 @@ PHP_FUNCTION(thrift_protocol_read_binary) {
     if (messageType == T_EXCEPTION) {
       zval* ex;
       MAKE_STD_ZVAL(ex);
-      createObject("TApplicationException", ex);
+      createObject("\\Thrift\\Exception\\TApplicationException", ex);
       zval* spec = zend_read_static_property(zend_get_class_entry(ex TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC);
       binary_deserialize_spec(ex, transport, Z_ARRVAL_P(spec));
       throw PHPExceptionWrapper(ex);